Comment 8 for bug 1102890

Revision history for this message
Matthew Paul Thomas (mpt) wrote : Re: Add OK button and Cancel button in indicator-datetime setting

Hello heyize and Jack. You seem to be describing two separate problems with the Time & Date panel. But it's not clear that "OK" and "Cancel" buttons would be good for either of these problems. So I want to be sure I understand you correctly.

The first problem: "When I change the time or date in the input text, it will not apply automatically. I need switch to the 'clock' tab to make the change saved." As you and Charles worked out, this problem is that when you change the time in the settings panel, the system time changes immediately (as you can verify in a terminal), but the clock menu doesn't update immediately. That can be fixed right away, and doesn't require any UI changes.

The second problem: "some times, the user may give up her settings." "OK" and "Cancel" buttons would help here, but only until you clicked "OK". And buttons with those labels imply that the window will close, which would be inconsistent with the rest of System Settings. The other suggestion, a "Revert" button, has the advantage that it could continue being available even after you'd made a change. Here's a wireframe of what it might look like.

There's another possibility: both "Revert" and "Apply" buttons. Including an "Apply" button would make the purpose of the "Revert" button more obvious. The tradeoff is that changes would no longer be instant-apply, inconsistent with most of the rest of System Settings.