Comment 6 for bug 1664232

Right, I just don't want to get code from random repositories.

So. Looking at this one package, here's my review. I didn't check the other ones, but please make sure that none of these same problems apply to those too.

I can see some copyrights that aren't mentioned in debian/copyright:

indicator-application/fixedtip.c: * Copyright (C) 2001 Havoc Pennington
indicator-application/fixedtip.c: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/fixedtip.h: * Copyright (C) 2001 Havoc Pennington, 2002 Red Hat Inc.
indicator-application/fixedtip.h: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/na-tray.c: * Copyright (C) 2002 Red Hat, Inc.
indicator-application/na-tray.c: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/na-tray.c: * Copyright (C) 2007 Christian Persch
indicator-application/na-tray-child.c: * Copyright (C) 2002 Anders Carlsson <email address hidden>
indicator-application/na-tray-child.c: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/na-tray-child.c: * Copyright (C) 2008 Red Hat, Inc.
indicator-application/na-tray-child.h: * Copyright (C) 2002 Anders Carlsson <email address hidden>
indicator-application/na-tray-child.h: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/na-tray-child.h: * Copyright (C) 2008 Red Hat, Inc.
indicator-application/na-tray.h: * Copyright (C) 2002 Anders Carlsson <email address hidden>
indicator-application/na-tray.h: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/na-tray-manager.c: * Copyright (C) 2002 Anders Carlsson <email address hidden>
indicator-application/na-tray-manager.c: * Copyright (C) 2003-2006 Vincent Untz
indicator-application/na-tray-manager.h: * Copyright (C) 2002 Anders Carlsson <email address hidden>
indicator-application/na-tray-manager.h: * Copyright (C) 2003-2006 Vincent Untz

I don't find Clement Lefebre, Sorokin Alexei or Martin Wimpress in the source files anywhere.

Tianjin KYLIN Information Technology Co., Ltd. neither - is that the entity which is claiming copyright on the packaging? If so, it would be more understandable if you put this in a "Files: debian/*" block. Or maybe they are the copyright holders of indicator-calendar/* or indicator-desktop/* or src/*, none of which have their license statement or copyright holders included. Could you please make the situation clearer? One way would be to include a license header in the files, another would be to document this in some other file in the repository. And could you include a COPYING file please?

Packaging: I don't think ukui-indicators.postinst does anything. The schema compiling should happen already via a dpkg trigger (in libglib2.0-0). So please could you confirm that for yourselves and then remove the file?

Trivial: Some files in debian/ have trailing whitespace and trailing new lines. It'd be nice to remove those & maybe configure your editor to highlight them.

debian/docs is empty.

debian/source/format: Unless you have a good reason or feel strongly, I think it would be better to make this 3.0 (quilt) and do proper upstream releases.

This last one is a big one. Please do *not* add any new code which depends on webkit 1. This is old unmaintained code that contains security vulnerabilities. All new webkit consumers need to be using webkit 2 now. We will at some point soon (but probably not for zesty) be attempting to remove the old webkit from Ubuntu completely.