Comment 2 for bug 1327458

Revision history for this message
Michael Terry (mterry) wrote :

Blockers:
- As noted, needs a fix for ppc64el
- Needs a team bug subscriber for whomever will look after this in Ubuntu
- ${gir:Depends} is empty, is there a missing "--with" argument to dh?
- The two following build warnings seem like actual problems. Can I get a comment on why they aren't problems or a fix for them? (Should just be setting a couple NULLs)
libuhttpmock/uhm-server.c: In function 'trace_to_soup_message':
libuhttpmock/uhm-server.c:912:17: warning: 'message' may be used uninitialized in this function [-Wmaybe-uninitialized]
  g_object_unref (message);
                 ^
libuhttpmock/uhm-server.c:849:32: warning: 'http_version' may be used uninitialized in this function [-Wmaybe-uninitialized]
  soup_message_set_http_version (message, http_version);
                                ^

Other Comments:
- I am not thrilled with this taking the presumably-desirable three-letter namespace uhm, but that was Debian's call
- The lib package should use "Pre-Depends: ${misc:Pre-Depends}"
- The dev package shouldn't ship the .a file, right?
- Would love to see a symbols file, please consider including one
- Love the tests!