Comment 0 for bug 1811129

[Impact]

This bug is the master bug for a one time SRU of ufw to the new 0.36 release. Typically patches would be individually backported like normal, but the new 'prepend' command feature is the impetus for this SRU and it contains most of the code changes. Other bugs fixes in the upstream release are either already included in the Ubuntu/Debian packaging or small enough to not pose a significant regression risk. 0.36 had various pyflakes/pep8/pylint cleanups over 0.35 so upgrading 18.04 to 0.36 will make maintaining ufw a bit easier for the duration of this LTS.

[Test Case]

In addition to the in-build tests, there is an extensive testsuite for running under root on the live system. The QRT tests for ufw (scripts/test-ufw.py) run these tests (and more).

[Regression Potential]

In terms of code changes, I've attached code-changes-bionic-to-disco.diff which is a diff of the source code in bionic's 0.35-5 with patches applied and disco's 0.36-1 with its patches applied. This shows that:

 * only comment changes to conf/sysctl.conf
 * only comment changes to conf/ufw.defaults
 * doc/systemd.example is updated (but unused in our packaging)
 * various man page updates
 * ufw.pot is refreshed
 * various Makefile updates related to snap packaging and coverage (the debian packaging only uses the 'clean' target)
 * src/applications.py has only whitespace and comment changes

The remaining code changes in src/ are quite small and address the SRU bugs and the regression potential for these changes will be discussed in those bugs.

[Other Info]

Note that the 0.36 code base has been the basis for the snap for many months with the majority of the non-'prepend' changes in production during this time. 0.36-1 was uploaded to Debian last month (and it migrated automatically to disco shortly after) with no new bug reports in either.

The snappy packaging, which is included upstream, underwent a lot of changes, but should not be considered as part of this SRU since it doesn't affect the deb builds.