Comment 8 for bug 1572525
Revision history for this message
| Alberto Mardegan (mardy) wrote Re: [regression] Double header height is set as flickable topMargin | #8 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
e3ace39
(Get the code!)
Hi Tim, I don't think that this behavioural change is related to the bugs fixed by that MP. I believe that those bugs can be fixed, while retaining the old (and documented) behaviour of setting the flickable margin to the height of the header. All what those bugs say, is about the margin behaviour when then flickable is *not* bound to the header (or is bound to an invisible header); but in fact, in fixing those bugs you also changed the behaviour of the flickable margin when it's attached to a visible header. I think that this part of the change could and should be left out.
Do we actually have any bugs filed by developers complaining that the flickable's topMargin is being overwritten when the flickable is attached to a header? If we don't let's not fix it. Besides, it's documented to behave like that, so I really see no point in changing it now.