TextField/TextArea: the touch area used for handle dragging often prevents double tap and long press from being taken into account
Bug #1389654 reported by
Florian Boucault
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Committed
|
High
|
Florian Boucault | ||
Bug Description
Steps to reproduce:
1. Type some text in a TextField or TextArea
2. Long press or double tap close to where the cursor and handle (also called caret) are
Current result:
Nothing happens
Expected result:
The word double tapped on should become selected.
Related branches
lp:~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk
- Cris Dywan: Approve
- Zoltan Balogh: Approve
- Zsombor Egri: Pending requested
- Tim Peeters: Pending requested
-
Diff: 720 lines (+286/-155)12 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+7/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+94/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 720 lines (+286/-155)12 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+7/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+94/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
- Cris Dywan (community): Needs Fixing
- Tim Peeters: Pending requested
- Zsombor Egri: Pending requested
- Zoltan Balogh: Pending requested
-
Diff: 779 lines (+310/-183)12 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+30/-28)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+95/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 485 lines (+160/-108) (has conflicts)10 files modifiedmodules/Ubuntu/Components/InputHandler.qml (+6/-2)
modules/Ubuntu/Components/Popups/Popover.qml (+4/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+120/-99)
modules/Ubuntu/Components/TextField.qml (+2/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+14/-3)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+0/-3)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
push_to_phone.sh (+8/-0)
Revision history for this message
| Florian Boucault (fboucault) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Undecided → Critical |
Revision history for this message
| Florian Boucault (fboucault) wrote | #2 |
| Changed in ubuntu-ui-toolkit: | |
| milestone: | none → 11.07 |
| assignee: | nobody → Florian Boucault (fboucault) |
| tags: | added: rtm14 |
| tags: | added: copy-paste |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → In Progress |
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #4 |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Critical → High |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Florian Boucault (fboucault) |
| importance: | Undecided → High |
| status: | New → In Progress |
| no longer affects: | ubuntu-ui-toolkit |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
Technically the 2 MouseArea in TextCursor.qml eats the events that then never reach the MultiPointTouchArea in InputHandler which is below in the stack.