Ubuntu UI Toolkit

[TOPBLOCKER] [SDK] Text selection - can't drag the handle

Bug #1371206 reported by Giorgio Venturi
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Florian Boucault
Ubuntu UI Toolkit 11.07
Ubuntu UX
Fix Released
Critical
Unassigned
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Florian Boucault

Bug Description

When in insert mode, I can't drag the handle in a new position

UX Spec
https://docs.google.com/a/canonical.com/document/d/1nFm8xiYhKXXuEO_IvMXoD0lASbYzYXva1BWMVanU3iw/edit#bookmark=kix.x877v0jqsn42

See original description

Related branches

lp:~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle
PS Jenkins bot: Needs Fixing (continuous-integration)
Ubuntu SDK team: Pending requested
Diff: 25 lines (+4/-4)
1 file modified
modules/Ubuntu/Components/TextCursor.qml (+4/-4)
lp:~fboucault/ubuntu-ui-toolkit/text_input_handle_area_visible
lp:~fboucault/ubuntu-ui-toolkit/text_input_larger_selection_handle_on_trunk
Cris Dywan: Approve
Zoltan Balogh: Approve
Zsombor Egri: Pending requested
Tim Peeters: Pending requested
Diff: 720 lines (+286/-155)
12 files modified
modules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+7/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+94/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
PS Jenkins bot: Needs Fixing (continuous-integration)
Ubuntu SDK team: Pending requested
Diff: 720 lines (+286/-155)
12 files modified
modules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+7/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+94/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
Cris Dywan (community): Needs Fixing
Tim Peeters: Pending requested
Zsombor Egri: Pending requested
Zoltan Balogh: Pending requested
Diff: 779 lines (+310/-183)
12 files modified
modules/Ubuntu/Components/InputHandler.qml (+4/-2)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+135/-99)
modules/Ubuntu/Components/TextField.qml (+30/-28)
modules/Ubuntu/Components/TextInputPopover.qml (+20/-5)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+2/-1)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
tests/autopilot/ubuntuuitoolkit/base.py (+16/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+95/-12)
tests/unit_x11/tst_components/tst_textinput_common.qml (+1/-33)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+1/-2)
Superseded for merging into lp:ubuntu-ui-toolkit
PS Jenkins bot: Needs Fixing (continuous-integration)
Ubuntu SDK team: Pending requested
Diff: 485 lines (+160/-108) (has conflicts)
10 files modified
modules/Ubuntu/Components/InputHandler.qml (+6/-2)
modules/Ubuntu/Components/Popups/Popover.qml (+4/-0)
modules/Ubuntu/Components/Popups/PopupBase.qml (+3/-1)
modules/Ubuntu/Components/TextArea.qml (+2/-0)
modules/Ubuntu/Components/TextCursor.qml (+120/-99)
modules/Ubuntu/Components/TextField.qml (+2/-0)
modules/Ubuntu/Components/TextInputPopover.qml (+14/-3)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+0/-3)
modules/Ubuntu/Components/plugin/ucmousefilters.cpp (+1/-0)
push_to_phone.sh (+8/-0)
Giorgio Venturi (giorgio-venturi-deactivatedaccount)
Changed in ubuntu-ux:
status: New → Fix Committed
assignee: nobody → Giorgio Venturi (giorgio-venturi)
description: updated
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit:
assignee: nobody → Christian Dywan (kalikiana)
Cris Dywan (kalikiana)
tags: added: rtm14
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

The feature is working, it can be difficult to initially grab the handle as the touch point is small

tags: added: touch-2014-10-02
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Christian Dywan (kalikiana)
Changed in ubuntu-ui-toolkit:
importance: Undecided → High
status: New → Confirmed
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit:
milestone: none → 10.09
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit:
milestone: 10.09 → 11.07
Giorgio Venturi (giorgio-venturi-deactivatedaccount)
tags: added: text-selection
Giorgio Venturi (giorgio-venturi-deactivatedaccount)
Changed in ubuntu-ux:
importance: Undecided → Critical
Florian Boucault (fboucault)
tags: added: copy-paste
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Please land AFTER 10-30 build

tags: added: touch-2014-11-06
removed: touch-2014-10-02
Changed in ubuntu-ui-toolkit:
importance: High → Critical
Pat McGowan (pat-mcgowan)
summary: - [SDK] Text selection - can't drag the handle
+ [TOPBLOCKER] [SDK] Text selection - can't drag the handle
Revision history for this message
Florian Boucault (fboucault) wrote :

Conclusion from meeting: make sure that the touch area for each handle is a 4GU square.

Florian Boucault (fboucault)
Changed in ubuntu-ui-toolkit:
assignee: Christian Dywan (kalikiana) → Florian Boucault (fboucault)
status: Confirmed → In Progress
Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → In Progress
assignee: Christian Dywan (kalikiana) → Florian Boucault (fboucault)
importance: High → Critical
Revision history for this message
Florian Boucault (fboucault) wrote :

Fix is ready but blocked on https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1389654

Revision history for this message
Florian Boucault (fboucault) wrote :

A workaround for bug #1389654 blocking the resolution has been devised:
- make sure that when double tapping or long pressing on or close to the handle, the adequate popup appears, either the select mode one (cut/copy/paste) if there is a selection already, or the insert mode one (select all/paste) if there is no selection yet
- add an extra option to the insert mode popup (select all/paste) called 'select' that when activated triggers the selection on the left of the cursor/handle

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

downgrade as it landed in rtm

Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Critical → High
Changed in ubuntu-ui-toolkit:
importance: Critical → High
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Released
Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
Giorgio Venturi (giorgio-venturi-deactivatedaccount)
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.