Resetting PIN/passcode/password lock doesn't work

[Michał Sawicz]

Steps to reproduce:
* enable PIN/passcode lock
* switch back to swipe
* type in your PIN/passcode

Expected:
* swipe is selected as the chosen lock mode
* device does not have a lock any more

Current:
* password is selected as the chosen lock mode
* device still has a lock enabled, displays a full keyboard because it doesn't know it's a PIN

It's impossible to switch away from a password as well.

ProblemType: Bug
DistroRelease: Ubuntu 14.10
Package: ubuntu-system-settings 0.3+14.10.20140822.1-0ubuntu1
Uname: Linux 3.4.67 armv7l
ApportVersion: 2.14.6-0ubuntu2
Architecture: armhf
Date: Mon Aug 25 11:40:17 2014
InstallationDate: Installed on 2014-08-25 (0 days ago)
InstallationMedia: Ubuntu Utopic Unicorn (development branch) - armhf (20140825-020205)
SourcePackage: ubuntu-system-settings
UpgradeStatus: No upgrade log present (probably fresh install)

[Pat McGowan (pat-mcgowan)]

I saw this occur once, but I find it is not possible to reproduce every time.

After unset on the passcode, the lock security panel briefly shows passphrase enabled, then switches to swipe, so may be some sort of race there.

[Michael Terry (mterry)]

Oddly, this works on utopic images. But apparently doesn't on RTM.

[Michał Sawicz (saviq)]

Didn't work for me on utopic images either.

[Michael Terry (mterry)]

Looks like this is a reliable reproduction sequence:

1) killall polkitd
2) Close System Settings if open
3) Open System Settings
4) Try to switch to swipe, but enter the wrong password
5) Try to switch to swipe, but enter the right password

[Michael Terry (mterry)]

This bug was fixed in the package ubuntu-system-settings -
0.3+14.10.20140829.1-0ubuntu1

---------------
ubuntu-system-settings (0.3+14.10.20140829.1-0ubuntu1) utopic; urgency=low

  [ Michael Terry ]
  * When changing to swipe mode, it was possible that our policykit
    agent would not unregister itself, making the next attempt to change
    modes appear to work, but in truth fail. Also, no longer ask for a
    password to switch to swipe mode if policykit has a cached
    authentication for us. (LP: #1350381)

  [ Sebastien Bacher ]
  * [security] tweak some pin locking details to match the design better
 -- Ubuntu daily release <email address hidden> Fri, 29 Aug 2014 05:19:18 +0000

[Selene ToyKeeper (toykeeper)]

So, on krillin rtm image 6, I can enable passphrase lock mode and it seems to work. If I switch back to swipe, it asks me for the passphrase then sets the lock back to swipe. Also seems to work fine.

Same thing if I switch it to PIN and then back to swipe. The screen briefly selects 'passphrase' but after a split second the UI selects 'swipe' and the change takes effect.

However, after installing rtm silo 003 (contains a bugfix for this and bug 1350381), it no longer works. What happens is:
- Select 'passphrase'.
- Enter a passphrase twice, and click 'set'.
- The screen freezes for a few seconds, then a dialog pops up saying "Could not set security mode", wanting me to enter the passphrase again.
If I then hit 'cancel', it goes away and I can see the changes actually took effect. Unlocking requires a passphrase.

Then if I select 'swipe' right after unlocking the screen, when the auth token should still be fresh, it asks me to enter the passphrase to switch to swipe... which means the other bug wasn't totally fixed either. But I can at least just hit 'cancel' and have the phone switch back to 'swipe' mode.

So, it asks for a passphrase in at least two situations where it shouldn't.

[Michael Terry (mterry)]

Using rtm image 11 and silo rtm-003, I have not been able to confirm ToyKeeper's findings. As far as I can tell, the bug is fixed (using reproduction steps in comment 5) and I don't see the new bug reported in comment 7.

So I need more help in reproducing the problem. Will try to catch ToyKeeper on IRC.

[Ken VanDine (ken-vandine)]

I was able to reproduce the new bug with ubuntu-rtm/14.09-proposed image 19 on mako using silo 3. However I couldn't reproduce the original bug that was fixed with this.

[Michael Terry (mterry)]

This is Ken's description of what he did to reproduce:

<kenvandine> mterry, ok... i reproduced ToyKeeper's issue
 mterry, i can't reproduce the old bug though :)
 mterry, so i went from none to passphrase (not pin)
<kenvandine> entered a 4 digit passphrase twice
 and it hung for a few seconds then told me it failed
<kenvandine> mterry, now i can't change it
<kenvandine> mterry, also... i've confirmed i can't reproduce her new bug without silo 3
 mterry, so the original bug is fixed, but this regression was introduced

I must be doing something differently or having my phone start with a different state. Because I just can't reproduce. Cluebats welcome.

[Michael Terry (mterry)]

Just a quick update -- I did manage to reproduce some oddities. Not all the time, but reliable enough now for me to try to track down source. Working on it.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+14.10.20140904-0ubuntu1

---------------
ubuntu-system-settings (0.3+14.10.20140904-0ubuntu1) utopic; urgency=low

  [ Andrea Cimitan ]
  * Various fixes for wifi wizard page (LP: #1362296)

  [ Sebastien Bacher ]
  * [security] don't mark "%1" string as translatable
  * [security] give a translation context to the 'None' string (LP:
    #1362143)
  * [licenses] display an error when the copyright can't be read (LP:
    #1206150)

  [ Michael Terry ]
  * Avoid another race condition when switching password types by
    completing all DBus operations synchronously as we exit the
    policykit agent. LP: 1361137 (LP: #1361137)
  * Fix the OSK not working on first boot. When the wizard closes, shut
    down maliit-server and the indicators so that unity8 can start them
    itself. LP: 1362679 (LP: #1362679)

  [ jonas-drange ]
  * [about] print out phone numbers for dual sims as well
  * [about/wifi] adding mac addresses for bt and wifi, and ip for wifi
    (LP: #1356239)
  * [language] explain to the user that a reboot is necessary for the
    change to take effect (LP: #1240875)
 -- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 00:59:05 +0000

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-system-settings - 0.3+14.10.20140904.2~rtm-0ubuntu1

---------------
ubuntu-system-settings (0.3+14.10.20140904.2~rtm-0ubuntu1) 14.09; urgency=low

  [ Ken VanDine ]
  * Tweak the depends for accountsservice-ubuntu-schemas to handle a "~"
    version

  [ CI bot ]
  * Resync trunk
 -- Ubuntu daily release <email address hidden> Thu, 04 Sep 2014 21:04:28 +0000