Comment 22 for bug 1548887

ubuntu-snappy:

- Needs a team bug subscriber.

- golang-snappy-dev should be renamed golang-github-ubuntu-core-snappy-dev (only goget-ubuntu-touch depends on it).

- Plenty of tests, but the integration suite doesn't seem to be run. Should probably be part of a dep8 test, eh? This is an important enough package that a dep8 suite should exist.

- I get a test failure when building locally (group_linux_test.go:72: groupTestSuite.TestGetgrnamNoSuchGroup). But I don't see this in a chroot. I don't really have 'no-such-group-really-no-no' on my system. Not sure what that's about. Do you see this?

- What's with the (tiny) bundled oauth bits? Didn't want to use golang-golang-x-oauth2-dev? (or something else, I'm not familiar with the Go communities' preferred oauth library) There's a FIXME about oauth2 not being available. On our servers? It's not a complicated chunk of code anyway, but it sticks out.

- I see we have a bundled copy of xgettext-go (which isn't shipped). It's not a blocker to remove it, but it seems only used in vivid. Can we just drop it?

- Are there other bundled packages (besides xgettext-go) in here? I didn't see any on a cursory scan, but there are a lot of directories.

- No man pages for snapd or snap?

- I'll skip the security pass since Jamie is heavily involved upstream.

- There are plenty of bugs of all severities in upstream and ubuntu trackers, but snappy is in rapid development and actively maintained, so I'm not worrying about that.

That's all I noticed now, as a packaging lookover.