Comment 2 for bug 1797209

On Thu, Oct 11, 2018 at 09:41:42AM -0000, Iain Lane wrote:
> I saw this in the unapproved queue and have the following questions:
>
> What's the reason for singling out the libc6 reboot-required reason
> rather than asking for *any* reboot-required?

At the end of the release upgrade you'll be required to reboot anyway so
it seemed redundant to have people reboot because evolution-data-server
or the kernel were upgraded when they'll have to reboot after the
upgrade.

> If you do strongly want to keep it limited to libc6 only, wouldn't
> opening the file in the python code instead of opening a grep subprocess
> be faster?

Ah yeah, I'll do that.

> I'm semi-convinced by your reasoning on untranslated strings, but if we
> could make some effort towards getting as many as possible I'd be
> happier, such as mailing the translator list so it gets in the next
> langpack refresh in bionic. (And it seems to me like if the string could
> avoid mentioning "libc6" that would be more friendly to any future
> tweaks in this area.)

Okay, I'll make the error message more generic.

> Is it right to say that this could equally be a 0-day SRU and so this
> upload isn't important for the release itself - there's no need to rush
> it in for final freeze?

Yes, that's true but we really need to fix it in Ubuntu 18.04 as
do-release-upgrade is run from the package on the system being upgraded
and not from the dist-upgrader tarball. So even if its not accepted
right now I think the SRU team would appreciate a we'll accept this as a
0-day SRU comment.

--
Brian Murray