SRU: add a postinst script to rm livecd-rootfs' unminimize

Bug #2072699 reported by Utkarsh Gupta
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-meta (Ubuntu)
Fix Released
Undecided
Utkarsh Gupta
Noble
Fix Released
Undecided
Utkarsh Gupta
unminimize (Ubuntu)
Fix Released
Undecided
Utkarsh Gupta
Noble
Fix Released
Undecided
Utkarsh Gupta

Bug Description

[ Impact ]

Right now, livecd-rootfs ships an unminimize script in /usr/local/sbin/unminimize. With unminimize now separately packaged and available in Noble+, we'd like to ensure there's only 1 unminimize script installed in a cloud image or a ubuntu-server minimal setup. This means, we'd like to drop the unminimize that is being shipped via livecd-rootfs.

Also, once this is fixed in the unminimize package in Noble, we'd like to seed
this package, too, so there'll be an update to ubuntu-meta with the seed changes, as done for Oracular already.

[ Test Plan ]

- Build cloud and server minimal image
- Install unminimize from -proposed.
- Confirm there's only unminimize in /usr/bin/unminimize and not in /usr/local/sbin/unminimize.

Post ubuntu-meta changes, the installation of the package won't be needed as it'll now be seeded so should be available by default. :)

- Build cloud and server minimal image
- Confirm there's only unminimize in /usr/bin/unminimize and not in /usr/local/sbin/unminimize.

[ Where problems could occur ]

The problems could occur if the user has their own set up in /usr/local/sbin/unminimize or if we accidentally delete something in /usr/local/* but we try and take care of this edge case by grepping a string in the unminimize script and only then delete the file.

Utkarsh Gupta (utkarsh)
Changed in unminimize (Ubuntu):
status: New → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The grepping for the comment string seems a bit hacky, but then again I don't consider this a risky change.

Changed in unminimize (Ubuntu Noble):
status: New → Fix Committed
tags: added: verification-needed verification-needed-noble
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Utkarsh, or anyone else affected,

Accepted unminimize into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/unminimize/0.2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hello,

I've tested an image built via ubuntu-bartender and using livecd-rootfs from proposed -

$ ubuntu-bartender --build-provider gce --hook-extras-dir "$(pwd)/cpc_packaging.extra" --livecd-rootfs-branch ubuntu/noble -- --series noble --project ubuntu-cpc --image-target qcow2 --subproject minimized

I ran unminimize on that and could confirm that there's only one script that was installed on the disk which is /usr/bin/unminimize. The postrm seems to be working as intended.

tags: added: verification-done-noble
removed: verification-needed-noble
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

> I've tested an image built via ubuntu-bartender and using livecd-rootfs from proposed -

There was nothing in the bug test plan or description saying it would require livecd-rootfs from proposed. I checked what version that would be, and at least today it's also in updates:

 livecd-rootfs | 24.04.69 | noble | source
 livecd-rootfs | 24.04.74 | noble-proposed | source
 livecd-rootfs | 24.04.74 | noble-updates | source

Publication date of livecd-rootfs to noble-updates according to LP is today, just 5h ago, and your comment is from August 2nd, so what you used is in updates already, making this point moot. But you see the implications of not making it clear what version was used? :)

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unminimize - 0.2.1

---------------
unminimize (0.2.1) noble; urgency=medium

  [ Philip Roche ]
  * fix: No longer install LXD snap in unminimize script (LP: #2066903)

  [ Utkarsh Gupta ]
  * Add a postinst script to rm livecd-rootfs' unminimize. (LP: #2072699)
  * Add --no-messages to grep commands.

 -- Utkarsh Gupta <email address hidden> Thu, 11 Jul 2024 01:19:25 +0530

Changed in unminimize (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Andreas Hasenack (ahasenack) wrote : Update Released

The verification of the Stable Release Update for unminimize has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Utkarsh Gupta (utkarsh)
Changed in ubuntu-meta (Ubuntu):
status: New → Fix Released
Changed in ubuntu-meta (Ubuntu Noble):
status: New → In Progress
Changed in ubuntu-meta (Ubuntu):
assignee: nobody → Utkarsh Gupta (utkarsh)
Changed in ubuntu-meta (Ubuntu Noble):
assignee: nobody → Utkarsh Gupta (utkarsh)
Changed in unminimize (Ubuntu):
assignee: nobody → Utkarsh Gupta (utkarsh)
Changed in unminimize (Ubuntu Noble):
assignee: nobody → Utkarsh Gupta (utkarsh)
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Utkarsh, or anyone else affected,

Accepted ubuntu-meta into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-meta/1.539.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-meta (Ubuntu Noble):
status: In Progress → Fix Committed
tags: added: verification-needed-noble
removed: verification-done-noble
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

For ubuntu-meta, I can confirm this is working as the seeds are doing the right thing and unminimize is being pulled into main and is present in the images by default.

Let's go! <3

tags: added: verification-done-noble
removed: verification-needed-noble
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-meta - 1.539.1

---------------
ubuntu-meta (1.539.1) noble; urgency=medium

  * Added unminimize to cloud-minimal, server-minimal. (LP: #2072699)

 -- Utkarsh Gupta <email address hidden> Fri, 09 Aug 2024 11:21:48 +0530

Changed in ubuntu-meta (Ubuntu Noble):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.