ubuntu-image looks fine, but should be fixed so the tests are passing and not coming up with errors (as right now one doesn't know if the tests are broken and not really passing, or if they are passing and udevadm is unnecessary):
[...]
test_make_disk_with_bare_parts (ubuntu_image.tests.test_builder.TestModelAssertionBuilder) ... sh: 1: udevadm: not found
sh: 1: udevadm: not found
ok
[...]
Otherwise it looks fine to me, there's a bug subscriber, etc. MIR approved.
ubuntu-image looks fine, but should be fixed so the tests are passing and not coming up with errors (as right now one doesn't know if the tests are broken and not really passing, or if they are passing and udevadm is unnecessary):
[...] disk_with_ bare_parts (ubuntu_ image.tests. test_builder. TestModelAssert ionBuilder) ... sh: 1: udevadm: not found
test_make_
sh: 1: udevadm: not found
ok
[...]
Otherwise it looks fine to me, there's a bug subscriber, etc. MIR approved.