Drop extra parameter from startpage URL when the default search is Yahoo

[Chris Coulson]

Bug 985862 added an extra parameter to the startpage URL, but this is only meant to be applicable for the Google variant. Currently, we add it to the Yahoo variant too (which is used when the default search provider is set to Yahoo)

[Chris Coulson (chrisccoulson)]

I've uploaded a fix for this to proposed. In addition to fixing this bug, I also removed the broken offline homepage feature and fixed the selection of the startpage variant so that it actually works correctly with locales other than en-US (or any locales where the Yahoo search plugin description is not just "Yahoo")

[Martin Pitt (pitti)]

Why is this fix this way around? Shouldn't it test against "google" and only append HOMEPAGE_GOOGLE_QUERY if it is? It seems this would not just affect Yahoo, but any other search engine as well?

[Chris Coulson (chrisccoulson)]

We just discussed this on IRC:

<pitti> chrisccoulson: question for you in bug 988283
<ubot2> Launchpad bug 988283 in ubufox "Drop extra parameter from startpage URL when the default search is Yahoo" [Low,Triaged] https://launchpad.net/bugs/988283
<chrisccoulson> pitti - ah. so, the way this works currently is that we just append the default search provider name to the startpage URL. However, only http://start.ubuntu.com/12.04/Google/ and http://start.ubuntu.com/12.04/Yahoo/ actually exist. Everything else is just redirected to the google site
 so, if you select a non-google or non-yahoo search provider, we offer the google startpage
<pitti> chrisccoulson: ok; still seems strange to do it this way around
<chrisccoulson> which is why the check is that way around
<pitti> ok
 thanks for the explanation

So, basically, it is this way around because we offer Google as a fallback if you select a non-Google or non-Yahoo search provider, but we only offer Yahoo if you select Yahoo as the search provider.

[Martin Pitt (pitti)]

Hello Chris, or anyone else affected,

Accepted ubufox into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Chris Coulson (chrisccoulson)]

From the web console:

== Google ==
[16:25:25.080] GET http://start.ubuntu.com/12.04/Google/?sourceid=hp [HTTP/1.0 304 Not Modified 254ms]
[16:25:25.362] GET http://start.ubuntu.com/12.04/sprite.png [HTTP/1.0 304 Not Modified 293ms]

== Yahoo ==
[16:25:32.258] GET http://start.ubuntu.com/12.04/Yahoo/ [HTTP/1.0 200 OK 297ms]
[16:25:32.583] GET http://start.ubuntu.com/10.04/sprite.png [HTTP/1.0 200 OK 566ms]
[16:25:32.586] GET http://start.ubuntu.com/10.04/middle.png [HTTP/1.0 200 OK 425ms]

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubufox - 2.0.3-0ubuntu1

---------------
ubufox (2.0.3-0ubuntu1) precise-proposed; urgency=low

  * New upstream release v2.0.3
    - Drop the offline startpage fallback. ubuntu-docs hasn't provided the
      fallback homepage for a while now, leaving this feature completely broken
    - Fix selection of appropriate startpage variant by not relying on
      translated strings
    - Fix LP: #988283 - Drop extra parameter from startpage URL when the
      default search provider is Yahoo
 -- Chris Coulson <email address hidden> Wed, 25 Apr 2012 12:56:22 +0100