For 'P' cycle:
The variant name is also always prefixed with the layout name with makes it unnecessarily much longer. IMHO it would be worth to shorten it like:
=== modified file 'ubiquity/misc.py' --- ubiquity/misc.py 2011-09-02 11:59:28 +0000 +++ ubiquity/misc.py 2011-09-13 19:54:11 +0000 @@ -573,11 +573,14 @@ xpath = "//iso_639_3_entry[@part1_code='%s']" gconf_key = '/desktop/gnome/peripherals/keyboard/kbd/layouts' variants = [] + shown_variants = [] def process_variant(*args): if hasattr(args[2], 'get_name'): variants.append('%s\t%s' % (args[1].get_name(), args[2].get_name())) + shown_variants.append(args[2].get_name()) else: variants.append(args[1].get_name()) + shown_variants.append('default')
lang = locale.split('_')[0] fp = libxml2.parseFile('/usr/share/xml/iso-codes/iso_639_3.xml')
Unsolved is when to use shown_variant and when variant later on in misc.py ;)
Achim
For 'P' cycle:
The variant name is also always prefixed with the layout name with makes it unnecessarily much longer. IMHO it would be worth to shorten it like:
=== modified file 'ubiquity/misc.py' 639_3_entry[ @part1_ code='% s']" gnome/periphera ls/keyboard/ kbd/layouts' variant( *args):
variants. append( '%s\t%s' % (args[1] .get_name( ), args[2] .get_name( ))) append( args[2] .get_name( ))
variants. append( args[1] .get_name( )) append( 'default' )
--- ubiquity/misc.py 2011-09-02 11:59:28 +0000
+++ ubiquity/misc.py 2011-09-13 19:54:11 +0000
@@ -573,11 +573,14 @@
xpath = "//iso_
gconf_key = '/desktop/
variants = []
+ shown_variants = []
def process_
if hasattr(args[2], 'get_name'):
+ shown_variants.
else:
+ shown_variants.
lang = locale. split(' _')[0] parseFile( '/usr/share/ xml/iso- codes/iso_ 639_3.xml' )
fp = libxml2.
Unsolved is when to use shown_variant and when variant later on in misc.py ;)
Achim