Comment 3 for bug 851160

Revision history for this message
Achim Bohnet (allee) wrote :

For 'P' cycle:

The variant name is also always prefixed with the layout name with makes it unnecessarily much longer. IMHO it would be worth to shorten it like:

=== modified file 'ubiquity/misc.py'
--- ubiquity/misc.py 2011-09-02 11:59:28 +0000
+++ ubiquity/misc.py 2011-09-13 19:54:11 +0000
@@ -573,11 +573,14 @@
     xpath = "//iso_639_3_entry[@part1_code='%s']"
     gconf_key = '/desktop/gnome/peripherals/keyboard/kbd/layouts'
     variants = []
+ shown_variants = []
     def process_variant(*args):
         if hasattr(args[2], 'get_name'):
             variants.append('%s\t%s' % (args[1].get_name(), args[2].get_name()))
+ shown_variants.append(args[2].get_name())
         else:
             variants.append(args[1].get_name())
+ shown_variants.append('default')

     lang = locale.split('_')[0]
     fp = libxml2.parseFile('/usr/share/xml/iso-codes/iso_639_3.xml')

Unsolved is when to use shown_variant and when variant later on in misc.py ;)

Achim