Comment 3 for bug 628906

Revision history for this message
Stéphane Graber (stgraber) wrote :

Attached a patch to completely disable the partition edit dialog on "activate".
That should fix Scott's issue but also means that double-clicking a row or pressing enter won't bring the partition edit dialog.

I just spent two hours reading through the code and QT's documentation trying to figure out how that function even gets called but couldn't figure it out ...

stgraber@castiana:~/Desktop/ubiquity$ grep -ri on_partition_list_treeview_activated .
./ubiquity/frontend/kde_components/PartMan.py: def on_partition_list_treeview_activated(self, index):
stgraber@castiana:~/Desktop/ubiquity$

So as I don't see any related connect() I don't see how I'd catch the double-click event to show the dialog on double-click.
The function takes two parameters, self (obviously) and another that's a QModelIndex object.
Neither give me any (obvious) way of guessing what event got triggered, so I don't seem to be able to guess if we received a click, double-click or a enter-pressed event.

I'm sure there's an "easy" way of doing it but I'm really not familiar with pyqt and there seems to be some magic in that code that I just don't understand :(

Unless someone knows how to implement the double-click part of the bug, I'd suggest we just apply the attached patch.

Also, if someone can tell me how that function even gets called, I'd be really interested :)

Thanks