GUI does not exit on reboot after install on armel

Bug #357101 reported by Paul Larson
6
Affects Status Importance Assigned to Milestone
libgksu (Ubuntu)
Fix Released
Undecided
Colin Watson
ubiquity (Ubuntu)
Fix Released
High
Colin Watson

Bug Description

On my babbage system, the gui seems to hang when I reboot after installing the system. If I reboot before install, it exits just fine and I see the message on the text console to remove the disc... and press enter. I can also switch between graphical and text consoles with ctrl-alt-fkeys. After a full install from the live image though, if I select reboot then it never exits the gui. The mouse and keyboard are hung and I cannot manually switch to tty1.

Paul Larson (pwlars)
affects: xserver-xorg-video-fbdev (Ubuntu) → ubiquity (Ubuntu)
Revision history for this message
Colin Watson (cjwatson) wrote :

I'm informed that this is essentially because gdm-signal is no longer in powermanagement-interface. I'm going to copy its source into ubiquity.

There is another slight glitch here though. We need to be able to check the DESKTOP_SESSION environment variable in ubiquity to check whether we're running in a GNOME session or not (and, in future, we'll need access to the environment variable that tells us how to connect to the session bus). Since we run as root, this requires getting gksudo to preserve those environment variables. Unfortunately, gksudo -k doesn't seem to work properly; it needs to pass the -E option to sudo. I have a patch to fix this but will want some extra eyeballs on it.

Changed in ubiquity (Ubuntu):
assignee: nobody → cjwatson
importance: Undecided → High
status: New → Triaged
Revision history for this message
Colin Watson (cjwatson) wrote :
Revision history for this message
Loïc Minier (lool) wrote :

Patch looks good

Revision history for this message
Loïc Minier (lool) wrote :

I see there's special handling for some env vars such as DISPLAY and XAUTHORITY in libgksu; exporting all env vars might be a bit intrusive so I'm checking with upstream and I just mailed <email address hidden> to tell him about this proposed change.

Revision history for this message
Loïc Minier (lool) wrote :

I can't think of terribly elegant ways to check for a running ubuntu gnome-session as root apart of looking at process list; concerning dbus you can read the needed env from something like .dbus/session-bus/$(cat /var/lib/dbus/machine-id)-$DISPLAY[2]

Revision history for this message
Colin Watson (cjwatson) wrote :

I don't export all environment variables by default here - only if you use the -k option, which explicitly asks libgksu to preserve the environment. This is a fix to cope with recent-ish changes in how sudo works, not a change in libgksu's contract.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libgksu - 2.0.9-1ubuntu3

---------------
libgksu (2.0.9-1ubuntu3) jaunty; urgency=low

  * 22_sudo_keep_env.patch: If gksudo -k is used, pass the -E option to sudo
    to preserve the environment if we're allowed to do so (LP: #357101).

 -- Colin Watson <email address hidden> Wed, 08 Apr 2009 14:33:00 +0100

Changed in libgksu (Ubuntu):
status: New → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

(I agree it should go upstream though, since IIRC this was an upstream change to sudo. Thanks for drawing upstream's attention to this bug.)

Colin Watson (cjwatson)
Changed in ubiquity (Ubuntu):
status: Triaged → Fix Committed
Changed in libgksu (Ubuntu):
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Gustavo Noronha Silva (kov) wrote :

Hey, I will use this change upstream, yeah, thanks for the patch. I have been wondering what your opinions regarding gksu policykit are, while we're at it: http://live.gnome.org/gksu/

Thanks,

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 1.12.6

---------------
ubiquity (1.12.6) jaunty; urgency=low

  [ Colin Watson ]
  * GTK frontend:
    - Copy-and-paste gdm-signal from powermanagement-interface, since that
      package is no longer in main and is slated to go away. In future we
      ought to be able to use gnome-session D-BUS calls or similar for this
      work (LP: #357101).
  * Use gksudo --preserve-env / sudo -E so that we can check DESKTOP_SESSION
    from the GTK frontend, and use other desktop environment variables in
    future.
  * Try a couple of different locations for NetworkManager's init script
    (LP: #356813).
  * Sync with console-setup 1.28ubuntu8: treat the Kazakhstan layout (kz) as
    non-Latin (LP: #356816).
  * Work around a debconf bug which broke the default time zone for some
    countries: REGISTER does not appear to give a newly-registered question
    the same default as the question associated with its template, unless we
    also RESET it, so do that (LP: #356794).
  * Update translations from Launchpad.
  * Automatic update of included source packages: base-installer
    1.98ubuntu6, console-setup 1.28ubuntu8, flash-kernel 2.13ubuntu6,
    partman-auto 84ubuntu3, partman-base 129ubuntu7, partman-target
    58ubuntu7, user-setup 1.23ubuntu18.

  [ Evan Dandrea ]
  * Provide translation support for the format warning on the automatic
    partitioning page, and make it less tied to English grammar. Thanks
    Timo Jyrinki (LP: #356333).
  * Only show the migration-assistant page if we have items we can
    import.
  * Don't let the time zone map image grow larger than the original.
  * Automatic update of included source packages: migration-assistant
    0.6.4.

 -- Evan Dandrea <email address hidden> Thu, 09 Apr 2009 14:46:10 +0100

Changed in ubiquity (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Paul Larson (pwlars) wrote :

Confirmed fix in latest daily

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.