Comment 4 for bug 356333

Revision history for this message
Evan (ev) wrote :

I'm not sure I follow what you mean by "whatisreplaced". As for splitting it up into multiple strings, ignoring the necessity to violate English grammar and remove "and" from before the last item in the list, wouldn't word ordering in other languages make this impossible? That is, can we guarantee that in every language "this will delete" is followed by the list, which is followed by "it/them with", which is followed by the release name?

For clarity, I've included the code in question below. Note that l is a list of operating systems present on the disk in question.

                    # TODO evand 2008-11-05: i18n
                    if len(l) == 1:
                        txt = l[0]
                    if len(l) == 2:
                        txt = '%s and %s' % (l[0], l[1])
                    elif len(l) > 2:
                        l[-1] = 'and ' + l[-1]
                        txt = ', '.join(l)
                    txt = 'This will delete %s and replace' % txt
                    if len(l) > 1:
                        txt = txt + ' them with %s.' % get_release_name()
                    else:
                        txt = txt + ' it with %s.' % get_release_name()