Comment 11 for bug 927781

Revision history for this message
Rob Herring (r-herring) wrote :

Ideally, the original author should submit things upstream as they are the one which can argue why they did what they did. To start, checkpatch.pl needs to be run.

I don't think the reboot time support would work as intended by the RFC. It is the "pxe boot" command that the timeout should apply to (i.e. running the pxelinux loader). There is already a tftptimeout env var that could get used here. What happens on timeout probably needs some work. A reboot time of 0 also needs to be handled.

The other 2 options look useful to me if these are normally set.

Rob