Comment 7 for bug 1820226

Revision history for this message
Eduardo Barretto (ebarretto) wrote : Re: [Bug 1820226] Re: [MIR] twitter-bootstrap3 as dependency of mailman3

On Mon, 2019-06-03 at 05:54 +0000, Christian Ehrhardt  wrote:
> > - There are different versions of twitter-bootstrap in the archive,
> > after some
> > search we have that
>
> [...]
> > It is used in mailman-website where you can manage lists. It is
> > unclear to
> > me if the version 3 is a hard dependency.
>
> Yes it is, I have checked with upstream already for the same reason
> (expect to be longer maintained) but the move seems to be non
> trivial.
> So for now it is a hard dependency on v3
>

Thanks for confirming it!

> [...]
>
> > - No security relevant warnings or errors
> > dpkg-scanpackages: warning: Packages in archive but missing from
> > override file:
> > dpkg-scanpackages: warning: sbuild-build-depends-core-dummy
> > dpkg-scanpackages: info: Wrote 1 entries to output Packages file.
> > E: twitter-bootstrap3 changes: bad-distribution-in-changes-file
> > unstable
> > N: 4 tags overridden (1 error, 3 warnings)
>
> [...]
>
> > - Multiple (most from test code, which might be low priority)
> > NULL_RETURNS from Coverity analysis, mostly related to jquery.
> >
> >
> > Someone with better JS skills might want to check coverity results
> > before we ACK/NACK.
> >
> > Christian could you please assign someone to take a look on those
> > warnings?
>
> First of all thanks for the review Eduardo!
> Looking at your summary I wondered which warnings you meant.
> a) the few dpkg-scanpackage warnings
> b) the coverity report to be looked at with JS skills
>

Sorry for not being so clear, the warnings here means the coverity
report.