Comment 3 for bug 233784

Revision history for this message
Joseph Miller (josephcmiller2) wrote :

This patch adds printer redirection support. Please note that configure.in is broken and needs:

- pkg_modules="libpanelapplet-2.0"
+ pkg_modules+=" libpanelapplet-2.0"

and then autoconf needs to be run again before configure. This patch applies to tsclient-0.150 with no other patches applied to it. I do not know if this is appropriate or if I should have provided a patch with some of the other patches applied. If someone could tell me the proper way to do this, I would be grateful. Please know that I am not a GTK programmer and I don't really know the proper way to do things. I have copied most of this code from the Disk Drive redirection patch.

I don't like the sprintf that is used in support.c, I wonder if buffer overruns are possible and if this is a security risk. I used it to be uniform with the rest of the code.

I am not reporting this upstream because it appears that Ubuntu maintainers had to add the file redirection as it was not in the original code either. I'm hoping that Ubuntu maintainers will get to this in a timely manner. It's a silly feature to be missing. I think next I'd like to see that disk redirection be done for each of the mounted disks so that removeable media is more easily accessible in the terminal server.