Transmission should check server caps before using notification actions

Bug #334252 reported by Cody Russell on 2009-02-25
22
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Transmission
Fix Released
Unknown
transmission (Ubuntu)
Undecided
Martin Pitt

Bug Description

Binary package hint: transmission

Transmission uses notify_notification_add_action() without checking the server's capabilities.

Cody Russell (bratsche) wrote :
James Westby (james-w) wrote :

Hey Cody,

Your patch only shows the notification at all if actions are supported, is that
the intended behaviour?

Thanks,

James

Cody Russell (bratsche) wrote :

Nice catch, thanks very much James!

Martin Pitt (pitti) wrote :

Thanks, Cody. Can you please file that upstream as well and link the bug here, so that we are notified about upstream comments/changes?

Cody Russell (bratsche) on 2009-02-25
Changed in transmission:
assignee: nobody → pitti
Martin Pitt (pitti) wrote :

I'll upload that together with the sponsoring of 1.50 (bug 329161).

Changed in transmission:
status: New → Fix Committed
Cody Russell (bratsche) wrote :

Hi Martin, sorry.. I forgot to free the list of caps in the previous patch. This patch is correct.

Changed in transmission:
status: Unknown → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package transmission - 1.50-1ubuntu1

---------------
transmission (1.50-1ubuntu1) jaunty; urgency=low

  [ Andrew Starr-Bochicchio ]
  * Merge from debian unstable (LP: #329161), remaining changes:
   - debian/control:
    + Added replaces & provides clutch (now included as part of transmission).
    + Build-depends on quilt.
   - debian/rules:
    + Uncommented "include /usr/share/quilt/quilt.make".
    + Added patch/unpatch targets for Quilt.
    + Create a PO template during package build.
   - 20_add_X-Ubuntu-Gettext-Domain.diff: Add X-Ubuntu-Gettext-Domain
     to .desktop file.

  [ Martin Pitt ]
  * Add 01_check_notification_actions.diff: Check if notification
    agent supports actions, and do not use actions if not. (LP: #334252)

transmission (1.50-1) unstable; urgency=low

  * new upstream release (closes: #510743)
  * debian/control,
    debian/transmission-cli.install,
    debian/transmission-daemon.install: move transmission-remote to
    transmission-cli package (closes: #511572)
  * debian/control:
      - strip the "XS" prefix and use the official DM field name
      - changed build-dep on libcurl to "libcurl4-dev | libcurl-dev"

 -- Andrew Starr-Bochicchio <email address hidden> Thu, 26 Feb 2009 11:55:50 +0100

Changed in transmission:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.