Comment 4 for bug 1888656

Revision history for this message
linrunner (linrunner) wrote :

Hi, i'm TLP's upstream/author.

> but shellcheck isn't entirely happy
I do shellchecks for every TLP release (there even is a Makefile target for it) but didn't re-check with 20.04 before the 1.3 release. My bad. Feel free to make use of my commit:

https://github.com/linrunner/TLP/commit/5934be84c8d934d8d37b73db28a291751d1f6831

There is nothing critical, the SC2034's are all for sysfs paths/filenames that never contain blanks.

> so I feel this might break at any time and then will need attention. The open Debian bugs kind of reflect this.

Of course any software may break at any time ;). The very few Debian and Ubuntu bugs so far only tell that TLP may expose malfunctions in kernel driver power saving, which is to be expected but not relevant when talking about hardware enabled OEM laptops with customized TLP configuration.

The majority of entries in TLP's upstream issue tracker is about kernel issues too.

I can say without immodesty that TLP itself breaks very rarely.