Ubuntu
thunderbird package

  1. Bug #939657
  2. Comment #4

Comment 4 for bug 939657

Revision history for this message
In , Karlt (karlt) wrote :

Comment on attachment 586912
Don't call g_settings_new each time we look up system proxy settings

Thanks for this. I was surprised to see how often GetProxyForURI is called,
and it is disturbing that this causes so much CPU use.
The approach in this patch makes sense.

Would mProxySettings be a better name than mGSettingsKeys?

Those who have "mode" set to "manual" are still going to see the same systems,
but fixing that is more involved, and that is a smaller portion of users. If you fix that also, then it might be a good idea to make nsGSettingsCollection hold a strong reference to mSettings, so that nsUnixSystemProxySettings doesn't need to keep its reference to mGettings.