Comment 48 for bug 849624

Revision history for this message
In , Philipp-bugzilla (philipp-bugzilla) wrote :

Clint, some of the work done in that patch has already been done in a previous bug, we already have a calendar-chrome-startup.js now, therefore some chunks are obsolete. I just attached my patch since it may provide some ideas for consolidating the two command line handlers.

I'd like to see a solution that doesn't just also implement the command line handler for lightning, but cleans up the code and creates a common command line handler, so that adding futher options doesn't require code changes in two locations. Also this would clean up the resources/ directory a bit more.

I like the idea of an idl interface for our command line handler to allow retrieving passed options via a component. This would easily allow adding more options.

If I would be doing the review, I'd probably r- the patch to consolidate the command line handlers (sorry ;-).