Comment 30 for bug 849624

Revision history for this message
In , Cmtalbert (cmtalbert) wrote :

Simon, David, Michiel, Sven, this bug is back on my radar after a while. I have read the comments here, and I'm still not totally sure that the patch I have for review is the approach we want. Can you guys comment about your view on this?

My thought is this:

If our options are these:
1. "Fix thunderbird to do this right"
2. "Use this about handler as a workaround"
3. "Do something else to get command control working"

Then this is how I see things:
1. We should file bugs and patches to fix Thunderbird to do this right. But we can't depend on that code because 1.0 Lightning will need to work with Thunderbird 2.0, and the liklihood of these changes getting onto the MOZILLA_1_8_BRANCH are not high (though it should be said that they are not zero either).

2. I think we can use this handler as a workaround for any "Thunderbird" bug/feature that is stated in part 1. I like this solution as a workaround because it is small, clean and will be easy to remove later. Of course, insert here the general disclaimer that workaround code shouldn't ever be checked in since it never gets removed.

3. Is there another way to add command line handlers to thunderbird? Didn't the old calendar extension have command line handlers? Can we still do this, or was that feature destroyed during the MOZILLA_1_8_BRANCH effort?

I look forward to hearing your thoughts. If we decide *not* to use the patch on this bug, then please clear the review request.