Keyboard Shortcut to Zoom (Ctrl ++) doesn't work until after menu Zoom

[Rob Frohne]

Binary package hint: thunderbird

To demonstrate this bug: Open thunderbird, click in the window pane with the message, try the shortcut (Ctrl ++). (Nothing happens no matter how many times you do. However, if you use the menu once to zoom, then the shortcut works just fine.

Rob

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: thunderbird 3.1.10+build1+nobinonly-0ubuntu0.11.04.2
ProcVersionSignature: Ubuntu 2.6.38-10.44-generic 2.6.38.7
Uname: Linux 2.6.38-10-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
CheckboxSubmission: b3f7c5231c874165f4d7945857608f87
CheckboxSystem: d00f84de8a555815fa1c4660280da308
Date: Wed Jun 8 07:36:55 2011
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: thunderbird
UpgradeStatus: Upgraded to natty on 2011-04-14 (55 days ago)

[Pjf-y (pjf-y)]

User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4) Gecko/20091027 Fedora/3.5.4-1.fc11 Firefox/3.5.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4 ThunderBrowse/3.2.6.5

After starting Thunderbird, using the Ctrl-+/- keyboard short cut does not have any effect on the font size for the message body unless the menu item (View -> Zoom -> Zoom in/out) is used first to magnify or decrease the font size. After that, the keyboard short cuts function as expected.

Reproducible: Always

Steps to Reproduce:
1. Start Thunderbird
2. Try to zoom the message body using Ctrl-+/- (should not work)
3. Use the menu item: View -> Zoom -> Zoom in/out to change the font size for the message body
4. The keyboard short cuts will now function as they should

[7-ludovic (7-ludovic)]

Anything in Tools -> Error console ?

This WFM on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.6pre) Gecko/20091103 Shredder/3.0pre

[Pjf-y (pjf-y)]

I have to apologize for not doing my homework first. Thunderbird only shows this behavior when the lightning add-on is enabled, otherwise the keyboard short cuts work as advertised. I'm running Lightning pre 1 on Fedora 11. I could not test with a more recent lightning as it does not appear to work.

[Standard8 (standard8)]

I see this, but only if you've opened the calendar tab first.

Opening the View -> Zoom sub-menu is enough to clear the error.

This seems to be a result of the way lightning is overlaying the menus - cmd_fullZoom* is now tab-implementation based so maybe it needs to be updated to the new way of doing things. This is the bit I suspect is getting in the way:

http://hg.mozilla.org/releases/comm-1.9.1/annotate/7fee9d989390/calendar/base/content/calendar-common-sets.js#l263

[Philipp-bugzilla (philipp-bugzilla)]

Yeah, we never really adapted our command controller to be fully tab specific. It would be nice to fix this for the beta. Not sure if we should block on it though. There are a few other bugs open with similar issues (i.e commands firing in both calendar tab and tasks tab, or calendar and mail tab, etc.

[Philipp-bugzilla (philipp-bugzilla)]

I have the feeling this may be a Thunderbird bug in the command controller code. I've locally changed things so that the command controller is no longer injected into the document and only provided via the tab API, but still the zoom commands are disabled on startup as soon as the calendar controller *supports* the command.

[Standard8 (standard8)]

So the calendar code may still be a problem (depending on how it manages its controllers at the moment), but you're right, Thunderbird is wrong - it isn't updating the view menu when we switch tabs, it only does that in view_init() which is when the view menu is opened... I think there's something we do for tabs around somewhere.

[Ssitter (ssitter)]

Bug 521026 mentions a similar issue with Thunderbird (with and without Lightning). The F8 key only works after opening the View menu once.
Maybe the root cause of this bug and Bug 521026 is the same.

[7-ludovic (7-ludovic)]

*** Bug 534189 has been marked as a duplicate of this bug. ***

[Florian Effenberger (floeff)]

Seems to work with the recent Lightning build from January? Can anyone confirm?

[Pjf-y (pjf-y)]

It does not seem to be fixed to me. I still need to visit the View->Zoom menu before zooming with a keyboard shortcut works properly.

[Florian Effenberger (floeff)]

Seems its the same with Alt+Shift+1|2|3 for changing the calendar view. It doesn't work at all when the application has the focus. If the menu bar has the focus, it works like a charm.

[brpaolo (brpaolo)]

I have this bug - Thunderbird 3.0.2 + Lightning 1.0b1 on Ubuntu 9.10. It is *really* annoying. It has always been my most used keyboard shortcut.

[Dgrimm-5 (dgrimm-5)]

Same here, in Win7 + Thunderbird 3.0.3 + Lightning 1.0b1

[Bugzilla-0 (bugzilla-0)]

*** Bug 553431 has been marked as a duplicate of this bug. ***

[Ken Saunders (kensaunders)]

Any progress on this bug?

[Lorenzo Bettini (bettini)]

this bug is still present in 3.0.4 in Ubuntu Lucid

[Don Dwiggins (don-dondwiggins)]

It's present for me in 3.1.1 on Windows with Lightning 1.0b2. I find I can enable the shortcut either by doing a View/Zoom or by visiting the Calendar tab.

This isn't critical (especially now that I know how to work around it), but it's certainly annoying.

[Florian Effenberger (floeff)]

Same for me -- 3.1.1, Lightning 1.0b2, OS X. Problem persists.

[Ssitter (ssitter)]

*** Bug 593849 has been marked as a duplicate of this bug. ***

[Bugzilla2007 (bugzilla2007)]

(In reply to comment #6)
> So the calendar code may still be a problem (depending on how it manages its
> controllers at the moment), but you're right, Thunderbird is wrong - it isn't
> updating the view menu when we switch tabs, it only does that in view_init()
> which is when the view menu is opened... I think there's something we do for
> tabs around somewhere.

Mark, if Thunderbird code is part of this problem, do we have a Thunderbird bug to fix that code? Something around somewhere may lead to nowhere...

[Ssitter (ssitter)]

*** Bug 597120 has been marked as a duplicate of this bug. ***

[7-ludovic (7-ludovic)]

*** Bug 597947 has been marked as a duplicate of this bug. ***

[Mingates1 (mingates1)]

On my Mac (Intel, OS 10.5.8) I was running Lightning 1.0b2, experiencing the same cmd key issue. I uninstalled Lightning 1.0b2, updated Thunderbird, then reinstalled Lightning 1.0b2 and got the same results.

Next, I uninstalled Lightning 1.0b2 and installed Google Calendar Tab,
https://addons.mozilla.org/en-US/thunderbird/addon/70768/ . It's working great and I can 'Zoom' in and out with the cmd keystroke upon opening the Thunderbird, without having the use the pulldown menu first.

[7-ludovic (7-ludovic)]

*** Bug 604859 has been marked as a duplicate of this bug. ***

[Davidbourguignon-net (davidbourguignon-net)]

Hi all,

Apparently the bug is still around and my eyes suffer... :-) I'm using Thunderbird 3.1.9 and the Lighting extension 1.0b2 -- it's a beta?

To get the zoom (CTRL + ±) feature back, the only option is currently to deactivate Lightning... :-(

By the way, it seems bug 639221 is a duplicate of this one, but I don't know how to mark this. (I guess one needs special admin rights for that).

Thanks in advance for your help!

[Bv1578 (bv1578)]

Now seems working on Thunderbird 3.3a4pre (Miramar):

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0pre) Gecko/20110405 Thunderbird/3.3a4pre
Lightning 1.0b4pre 20110418

created a new profile, installed Lightning, moved to a mail folder (it shows the "Welcome to Shredder" page) and Ctrl + +/- now works without opening first the Zoom menu.
Created and saved a mail, closed and restarted TB with the message tab open, Ctrl + +/- works.

Could someone confirm?

[Mozilla-3 (mozilla-3)]

For me, I have to press ctrl + several times before the text enlarges but then it works as expected. If I change "Edit > Preferences > Display > Fonts > Advanced > Minimum font size" from 17pt to None then ctrl + works immediately. I don't have to use the View menu at all.

I see the same behavior whether Lightning is enabled or not so there is a problem but for me it's not related to Lightning.

TB 3.1.9 / Lightning 2011-02-26 / Ubuntu 10.10

[Mozilla-3 (mozilla-3)]

p.s. Reproducible with some emails (e.g. from Bugzilla) but not all.

[Davidbourguignon-net (davidbourguignon-net)]

Thanks Pete for your comments. I don't observe this behaviour. In my case, it's closer to what the other bug reports have described: without Lightning the CRTL hot key works right off the bat for any type of emails (plain text, HTML, etc.) and without any delay.

However, as soon as the Lightning plug-in is switched on, this zoom feature disappears. After Lightning is switched off, it's back again. There is a bug, indeed. It's maybe not located in the Lightning code, however. Some developers have suggested it's located in Thunderbird (see Philipp Kewisch comments: "I have the feeling this may be a bug in the command controller code").

[Bv1578 (bv1578)]

David, Pete, could you try with a recent nightly for Thunderbird *3.3a4* and Lightning?

[Davidbourguignon-net (davidbourguignon-net)]

Hi Decathlon, I would be glad to, but no idea how to do this while keeping my Thunderbird 3.1.9 alive... When is this new version supposed to be released? Thanks for your help!

[Ken Saunders (kensaunders)]

(In reply to comment #31)
> Hi Decathlon, I would be glad to, but no idea how to do this while keeping my
> Thunderbird 3.1.9 alive... When is this new version supposed to be released?
> Thanks for your help!

These instructions are for installing and running multiple instances of Thunderbird, but they apply to all Mozilla applications, so once you learn it, you can get into trying out and testing new versions including those on the Nightly and Aurora channels. It's a great way to give back, and a great way to check out what's ahead.
These instructions are for Windows, but I've done the same on Linux with some slight variations.

Not sure where 3.3a4 is, but here's 3.3a4pre
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-aurora/

After downloading it, create a new folder (in your Program Files or anywhere else) name it Thunderbird 3.3a4 (or whatever), run the thunderbird-3.3a4pre.exe (will be Miramar) > select Custom > Next > Browse > select the new folder you created > complete the install.

Right click on the Miramar desktop shortcut select properties > Shortcut and add the following to the Target -no-remote -p
It would look something like this.
"C:\Users\Ken Saunders\Desktop\ \Miramar 3.3a4pre\thunderbird.exe" -no-remote -p

After double clicking on the Miramar shortcut, the Profile manager will appear. Be sure to uncheck "Don't ask at startup".
Create a new profile and you'll be good to go.

I had trouble with the account setup wiz, but that's a whole separate issue.

I hope this helps.

http://quality.mozilla.org/
To get into testing.

[Ken Saunders (kensaunders)]

Forgot to mention, be sure to uncheck "Launch Miramar now" after completing the setup or else you'll get a message stating something like Thunderbird is already in use (if you have it running).

[Bv1578 (bv1578)]

(In reply to comment #30)
> David, Pete, could you try with a recent nightly for Thunderbird *3.3a4* and
> Lightning?

(In reply to comment #32)
> Not sure where 3.3a4 is, ...

I apologize, in comment 30 I meant Thunderbird 3.3a4pre.

[Davidbourguignon-net (davidbourguignon-net)]

Thanks a lot Decathlon for your detailed feedback! I will install asap a Thunderbird test facility on my computer... Simply give me a few extra days, I'm currently swamped by many things. Since I have several other potential Thunderbird bugs to report, I guess this test facility will have many uses... :-) Thanks in advance, and talk to you soon!

[Bv1578 (bv1578)]

(In reply to comment #35)
> Thanks a lot Decathlon for your detailed feedback! I will install asap a

Actually the detailed feedback is by Ken Saunders ;-)
Anyway, don't waste your time in installing a different Thunderbird build only for testing this case (because, unless you want to try others features, you don't have to use it for your usual work).
Many people are currently trying Thunderbird 3.3a4pre, someone of them will do this simple test. :-)

[Davidbourguignon-net (davidbourguignon-net)]

Oops, sorry for that Decathlon. And my apologies to Ken for not acknowledging him.

In fact, I do have other features to try: I've collected other Thunderbird bugs in v3.1.9. But I'm a bit concerned about installing v3.3a4pre, missing a step and messing up my entire Thunderbird install, which I use heavily every day for professional purposes...

For these other possible issues in v3.1.9, would you be interested in a different kind of bug reporting? I could either share a video with you (using http://www.screenjelly.com/) or simply invite you to a screen-sharing session (using for example http://www.teamviewer.com/).

What do you think? Thanks in advance for your help.

[Vseerror (vseerror)]

*** Bug 639221 has been marked as a duplicate of this bug. ***

[Davidbourguignon-net (davidbourguignon-net)]

Hi all, I just installed Thunderbird 3.1.0 and tested it: this bug is gone! Thanks a lot for your impressive job. Have a great week-end!

[Adrian-dinu87 (adrian-dinu87)]

Hello, indeed i can confirm that the bug was fixed for me too.

[Philipp-bugzilla (philipp-bugzilla)]

Looks like this is fixed. If this still occurs for someone, please reopen.

[Pjf-y (pjf-y)]

Hi,
I originally reported this bug and now have to reopen it so perhaps you (you being anyone reading!) can test this to see if you get the same result. I have confirmed this behavior with two installations of Thunderbird 3.1.10 / Lightning 1.0b2 on Linux and one installation of the same versions on Windows XP and get the same result every time.

For me, Ctrl++, Ctrl+-, Ctrl+0 still will not work with a freshly started instance of Thunderbird, with the Calendar already opened, UNLESS the "View" menu is opened first. That is all that is required and none of the other menu item can substitute. Once the "View" menu item is opened, the shortcuts work as advertized. You do not have to select any item from the menu list and it works whether the "View" menu is selected via the keyboard or mouse.

Anyone care to confirm?

[Florian Effenberger (floeff)]

Can confirm that. With Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; de; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 it occurs. Maybe less often than before, didn't count, but it still happens.

[Lorenzo Bettini (bettini)]

with Lightning/1.0b2 Thunderbird/3.1.10 in Linux this problem doesn't occur anymore for me...

[Ken Saunders (kensaunders)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10

Keyboard shortcuts do not zoom content as they should until I hit Alt+v z enter (then they work as expected).
Just giving the View menu focus is not sufficient enough for me to enable the zooming shortcuts.

With Lightning disabled, they work properly the first time around (startup).

This is a nuisance. Not a major issue, but an unnecessary pain none the less.

[JJohnson (jtj-az)]

I noticed the Zoom hot key problem after updating to Ubuntu 10.04. Problem still exists in Ubuntu 11.04. Thunderbird version is: 3.1.10.

[7-ludovic (7-ludovic)]

*** Bug 670862 has been marked as a duplicate of this bug. ***

[JJohnson (jtj-az)]

Problem does not exist in Ubuntu 11.04, 64Bit; I'm using Thunderbird version 3.1.10 w/o Lightning installed because a 64Bit version is not available. It is also working in Firefox 5.0 with multiple tabs opened. Apparently Lightning is the culprit.

[Philipp-bugzilla (philipp-bugzilla)]

Sucks, but I think we don't need to solve this for 1.0

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Mattmail135-mozilla001 (mattmail135-mozilla001)]

I'm working with version 31 now, no Lightning, and find this problem has not gone away. It is also there in version 24 - I did install Lightning with that version after some time, but I have no recollection of this problem appearing after previously not existing - I think it was always there.

[Hah-mozbugz (hah-mozbugz)]

Created attachment 8929783
Workaround for the bug

The bug still exists in Thunderbird 52.4.0 in Ubuntu 16.04.3 LTS:
Without Lightning: Ctrl-+/Ctrl--/Ctrl-0 works.
With Lightning: Must first simply open and close the View menu, then the shortcut keys work.
With Lightning and the attached workaround patch: The shortcut keys work as expected, but it is now impossible to change the zoom level in the calendar view (which e.g. changes the number of weeks in the multiweek view) (the calendar zoom level is remembered, so you can just set the desired zoom level and then apply the patch).

[Håkon A. Hjortland (post-hakn)]

Upstream bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=526288