Comment 205 for bug 584632

Revision history for this message
In , Ehsan-mozilla (ehsan-mozilla) wrote :

(In reply to Jorg K from comment #118)
> Created attachment 8584620
> Here comes another manual test.
>
> Here some HTML to run a test by hand.
>
> If clicking behind any of the eight lines in this test, "DIV" will be
> returned in the current version of FF.
>
> With the new behaviour clicking behind lines 1-6 and 8, "#text" will be
> returned, but for the empty line 7, DIV is still returned.
>
> If the code were wrong, this line couldn't be clicked at all and the caret
> would move to the previous or subsequent line. I know, because at first my
> code didn't cater for this case.
>
> IMHO my test is correct, if you don't think so, please be more specific.

OK, I understand what you want to test now. So your test is actually correct, it was the comments where you mentioned clicking past the *second* line that confused me. :-)

> Changing the subject:
> I'd like to see this landed one day very soon. I'd also request to land it
> on mozilla38, so TB 38 can pick it up. I don't want to mention again that
> this is fixing a long-standing TB bug that people have been pulling their
> hair out for over 10 years now.

Sorry but this patch is not suitable for backporting into Aurora (which will soon become Beta) at this point, because it's quite risky in terms of the possibility to cause regressions. It needs to land on trunk and ride the trains. I understand that you'd like to see it fixed as soon as possible, but please be a bit more patient. :-)

> If you really want more tests to be written, I can do that, but *afterwards*
> ;-)

OK, that's fair. :-)