A good try line to use by default for editor changes is:
try: -b do -p all -u all[x64] -t none
This will build on all platforms (to detect compile errors), and will run tests only on 64-bit Linux (to avoid wasting resources). If there might be platform-specific test failures, remove the "[x64]", but I don't think you need to do that here.
For Mercurial -- if you're using mq (which you should), you don't ever want to do "hg commit". The patch you've attached is exactly right.
A good try line to use by default for editor changes is:
try: -b do -p all -u all[x64] -t none
This will build on all platforms (to detect compile errors), and will run tests only on 64-bit Linux (to avoid wasting resources). If there might be platform-specific test failures, remove the "[x64]", but I don't think you need to do that here.
For Mercurial -- if you're using mq (which you should), you don't ever want to do "hg commit". The patch you've attached is exactly right.
Here are the try results for you: https:/ /treeherder. mozilla. org/#/jobs? repo=try& revision= fd11f71e3daa