Comment 249 for bug 52667

(In reply to comment #190)
> Blake: as far as I can see, the code leaves the "reply to list" dropdown menu
> item (in contrast to the button) always enabled. I think you'll want to disable
> that, because the backend code then can't do anything meaningful, as it looks
> for the List-Post header which is not there. I think it falls back to normal
> reply, but that's then redundant in the UI and irritating result.

Yeah, I'll try to add this in tonight, asking in IRC for some pointers on how
to enable/disable menu items.

(In reply to comment #196)
> No: If I read the newsgroup, it should show "reply to newsgroup" as default
> button, and go to newsgroup.

This will be part of patch 3 (add the email addresses to the buttons), if I ever get patches 1 (change the default button) and 2 (add the Reply-To-List functionality) committed.

(In reply to comments #193 and #195)
> Please add trailing ';' - those are missing in quite a few places.

Done.

> Remove the debugger

Done.

> And there's also a lot of trailing whitespace (+ lines with only whitespace
> that should be empty.)

I've fixed the lines that I added with trailing whitespace/only whitespace. I
have left the lines with trailing whitespace that I didn't touch, to minimize
the diff. I'm happy to do a big patch which cleans up all the trailing
whitespace, but that's a different problem, and should probably go under a
different bug.

> I had the updating issue with only this patch applied too, fwiw.

Cool, that'll make it easier to track down. Is there any more info you can
give that will help me figure out what's going wrong? Steps to reproduce,
maybe?

I'll post a new patch once I've fixed the updating bug and disabled the reply-to-list menu item.

Thanks,
Blake.