Comment 146 for bug 369150

Revision history for this message
In , Martin-wilck (martin-wilck) wrote :

Created an attachment (id=348191)
patch against CVS 2008/11/14

Updated patch which addresses Neil's points.

> (2×) The "old" code used to have fallback
> e.g. decodedName.length() ? decodedName.get() : pNames
did it using !decodedName.IsEmpty? ...

> (6×) These should be converted to the form
> CopyUTF8toUTF16(outCString, recipient);
I did this for nsMsgCompose.cpp, but not for mimedrft.cpp, where NS_ConvertUTF8toUTF16() is used all over the place. I think that would be a separate cleanup patch.

The Message list display part (nsMsgDBView.cpp) got lost in attachment #343484, I re-added it. Without this, author names in the message list will still be broken.

The patch applies to today's CVS compiles and works (for me, at least).
Hope it's in time for the beta.