(From update of attachment 386024)
>+ // We're not really interested in this, but supply a check value anyway.
>+ PRBool checkValue;
Just call this dummyValue, saving you a comment ;-)
>+ // Error condition
>+ message.AssignLiteral("String ID ");
>+ message.AppendInt(aMsgId);
>+ FEAlert(message, aUrl);
I assume we only expect to hit this in development so we don't need to know which server is reporting the alert?
>+nsImapIncomingServer::GetFormattedStringFromName(const nsString &aName,
...
>+ result.AssignLiteral("Failed to get string named ");
s/get/format/ ;-)
>+imapLoginFailedRetryButton=Retry
No access key? (&Retry iirc)
(From update of attachment 386024)
>+ // We're not really interested in this, but supply a check value anyway.
>+ PRBool checkValue;
Just call this dummyValue, saving you a comment ;-)
>+ // Error condition AssignLiteral( "String ID "); AppendInt( aMsgId) ;
>+ message.
>+ message.
>+ FEAlert(message, aUrl);
I assume we only expect to hit this in development so we don't need to know which server is reporting the alert?
>+nsImapIncomin gServer: :GetFormattedSt ringFromName( const nsString &aName, AssignLiteral( "Failed to get string named ");
...
>+ result.
s/get/format/ ;-)
>+imapLoginFail edRetryButton= Retry
No access key? (&Retry iirc)