Comment 40 for bug 237341

Revision history for this message
In , Neil-httl (neil-httl) wrote :

Comment on attachment 8337339
fix bucket groups to be based off of a calendar week concept

Sorry for the delay. The code seems reasonable but this needs to have ui-review before I can review it properly.

>+ // TODO - in the calculation for thisWeek, the + 0 should be based of off
>+ // the localization for first day of calendar
If only it were that easy...

As a side note I'd like to compare to Firefox's History sidebar which uses the following groupings:
> Today
> Yesterday
> Last 7 days
> This month (if today is the 8th or later)
> 5 entries, one for each previous month
> Older than 6 months

Out of interest, Outlook seems to be use the following groupings:
> Today
> Yesterday
> 5 entries, one for each previous day
> Last Week (7-13 days ago)
> Two Weeks Ago (14-20 days ago)
> Three Weeks Ago (21-27 days ago)
> Earlier This Month
> Last Month
> Older
What I don't know is whether these groups are based on the day of the week or fixed numbers of days.