Comment 135 for bug 1215882

Revision history for this message
In , Alex Henrie (alexhenrie24) wrote :

Comment on attachment 8805031
Don't claim we are done when we failed

Review of attachment 8805031:
-----------------------------------------------------------------

Hi Kent, thanks for looking into this. If we are going to change the semantics of m_sendDone, it would be better to pass an aSendDone parameter to SendQuit and set m_nextStateAfterResponse based on aSendDone. However, there is still the problem of popping up 2 dialogs when only 1 of them has useful information.