thermald: fix default preference to ENERGY_CONSERVE
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
thermald (Ubuntu) |
Fix Released
|
Medium
|
Colin Ian King | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Yakkety |
Fix Released
|
Medium
|
Unassigned | ||
Zesty |
Fix Released
|
Medium
|
Colin Ian King |
Bug Description
[SRU][XENIAL]
Upstream thermald includes a minor fixes that ensure settings are initialized correctly. The fix in question is:
commit 37a25879239466f
Author: Srinivas Pandruvada <email address hidden>
Date: Mon Mar 27 17:39:30 2017 -0700
set default preference
In case there is missing element for preference, set ENERGY_CONSERVE
as default.
This fixes are not critical, but I think are proven stable enough for a SRU and it plugs a *potential* issue that we've not yet seen to occur.
[REGRESSION POTENTIAL]
Minimal, this ensures a default setting is correctly set to the default value when config is provided without a default preference. Since this is not the normal modus operandi of thermald since it uses zero config mode, this fix plugs a corner case that not used by default. Users of the xml config will be entering this default appropriately, so this catches the corner cases where it is not defined in a user config.
[TEST]
This is not testable in the default zero config case. In cases where the config does not have this default setting, it is hard to test as this is sets internal state that is not easily checked during run time. As this bug has not been observed in the field, it is hard to find a reproducer to test this corner case.
Changed in thermald (Ubuntu): | |
importance: | Undecided → Medium |
assignee: | nobody → Colin Ian King (colin-king) |
status: | New → In Progress |
description: | updated |
description: | updated |
description: | updated |
summary: |
- thermald: pull in some minor fixes from upstream + thermald: fix defailt preference to ENEGERY_CONSERVE |
summary: |
- thermald: fix defailt preference to ENEGERY_CONSERVE + thermald: fix default preference to ENEGERY_CONSERVE |
summary: |
- thermald: fix default preference to ENEGERY_CONSERVE + thermald: fix default preference to ENERGY_CONSERVE |
An upload of thermald to zesty-proposed has been rejected from the upload queue for the following reason: "Contains .pc junk, will be reuploaded.".