Activity log for bug #1683825

Date Who What changed Old value New value Message
2017-04-18 14:31:17 Colin Ian King bug added bug
2017-04-18 14:31:22 Colin Ian King thermald (Ubuntu): importance Undecided Medium
2017-04-18 14:31:24 Colin Ian King thermald (Ubuntu): assignee Colin Ian King (colin-king)
2017-04-18 14:31:27 Colin Ian King thermald (Ubuntu): status New In Progress
2017-04-18 14:50:34 Colin Ian King description [SRU][XENIAL][YAKKETY][ZESTY] Upstream thermald includes some minor fixes that ensure some settings are initialized correctly and fixes a 32 bit build warning. The fixes in question are: commit a8eba71a95b3b8af0540f6a93877e24bc8c47079 Author: Colin Ian King <colin.king@canonical.com> Date: Tue Mar 7 11:47:51 2017 +0000 thd_cdev: ensure _target_value is initialized commit 6a2344b4a55acc0cba356d0f7c521c0cdb6632e0 Author: Colin Ian King <colin.king@canonical.com> Date: Mon Mar 13 16:40:42 2017 +0000 Fix build warning on i386 architecture builds print out size as size_t type, use %zu format specifier to fix build warning on 32 bit i386: /usr/include/glib-2.0/glib/gmessages.h:342:43: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'std::vector<zone_trip_limits_t>::size_type {aka unsigned int}' commit 37a25879239466f2d096fd1a58b2ac7bbc3958f5 Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Date: Mon Mar 27 17:39:30 2017 -0700 set default preference In case there is missing element for preference, set ENERGY_CONSERVE as default. This fixes are not critical, but I think are proven stable enough for a SRU and fix some minor buglets that should be plugged. [SRU][XENIAL][YAKKETY][ZESTY] Upstream thermald includes some minor fixes that ensure some settings are initialized correctly and fixes a 32 bit build warning. The fixes in question are: commit 6a2344b4a55acc0cba356d0f7c521c0cdb6632e0 Author: Colin Ian King <colin.king@canonical.com> Date: Mon Mar 13 16:40:42 2017 +0000     Fix build warning on i386 architecture builds     print out size as size_t type, use %zu format specifier to     fix build warning on 32 bit i386:     /usr/include/glib-2.0/glib/gmessages.h:342:43: warning: format '%lu'     expects argument of type 'long unsigned int', but argument 4 has     type 'std::vector<zone_trip_limits_t>::size_type {aka unsigned int}' commit 37a25879239466f2d096fd1a58b2ac7bbc3958f5 Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Date: Mon Mar 27 17:39:30 2017 -0700     set default preference     In case there is missing element for preference, set ENERGY_CONSERVE     as default. This fixes are not critical, but I think are proven stable enough for a SRU and fix some minor buglets that should be plugged.
2017-04-18 14:53:44 Colin Ian King description [SRU][XENIAL][YAKKETY][ZESTY] Upstream thermald includes some minor fixes that ensure some settings are initialized correctly and fixes a 32 bit build warning. The fixes in question are: commit 6a2344b4a55acc0cba356d0f7c521c0cdb6632e0 Author: Colin Ian King <colin.king@canonical.com> Date: Mon Mar 13 16:40:42 2017 +0000     Fix build warning on i386 architecture builds     print out size as size_t type, use %zu format specifier to     fix build warning on 32 bit i386:     /usr/include/glib-2.0/glib/gmessages.h:342:43: warning: format '%lu'     expects argument of type 'long unsigned int', but argument 4 has     type 'std::vector<zone_trip_limits_t>::size_type {aka unsigned int}' commit 37a25879239466f2d096fd1a58b2ac7bbc3958f5 Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Date: Mon Mar 27 17:39:30 2017 -0700     set default preference     In case there is missing element for preference, set ENERGY_CONSERVE     as default. This fixes are not critical, but I think are proven stable enough for a SRU and fix some minor buglets that should be plugged. [SRU][XENIAL][YAKKETY][ZESTY] Upstream thermald includes a minor fixes that ensure settings are initialized correctly. The fix in question is: commit 37a25879239466f2d096fd1a58b2ac7bbc3958f5 Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Date: Mon Mar 27 17:39:30 2017 -0700     set default preference     In case there is missing element for preference, set ENERGY_CONSERVE     as default. This fixes are not critical, but I think are proven stable enough for a SRU and fix some minor buglets that should be plugged.
2017-04-18 15:29:54 Colin Ian King description [SRU][XENIAL][YAKKETY][ZESTY] Upstream thermald includes a minor fixes that ensure settings are initialized correctly. The fix in question is: commit 37a25879239466f2d096fd1a58b2ac7bbc3958f5 Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Date: Mon Mar 27 17:39:30 2017 -0700     set default preference     In case there is missing element for preference, set ENERGY_CONSERVE     as default. This fixes are not critical, but I think are proven stable enough for a SRU and fix some minor buglets that should be plugged. [SRU][XENIAL][YAKKETY][ZESTY] Upstream thermald includes a minor fixes that ensure settings are initialized correctly. The fix in question is: commit 37a25879239466f2d096fd1a58b2ac7bbc3958f5 Author: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Date: Mon Mar 27 17:39:30 2017 -0700     set default preference     In case there is missing element for preference, set ENERGY_CONSERVE     as default. This fixes are not critical, but I think are proven stable enough for a SRU and it plugs a *potential* issue that we've not yet seen to occur. [REGRESSION POTENTIAL] Minimal, this ensures a default setting is correctly set to the default value when config is provided without a default preference. Since this is not the normal modus operandi of thermald since it uses zero config mode, this fix plugs a corner case that not used by default. Users of the xml config will be entering this default appropriately, so this catches the corner cases where it is not defined in a user config. [TEST] This is not testable in the default zero config case. In cases where the config does not have this default setting, it is hard to test as this is sets internal state that is not easily checked during run time. As this bug has not been observed in the field, it is hard to find a reproducer to test this corner case.
2017-04-18 15:45:36 Colin Ian King summary thermald: pull in some minor fixes from upstream thermald: fix defailt preference to ENEGERY_CONSERVE
2017-04-18 15:45:45 Colin Ian King summary thermald: fix defailt preference to ENEGERY_CONSERVE thermald: fix default preference to ENEGERY_CONSERVE
2017-04-18 16:11:20 Andy Whitcroft thermald (Ubuntu Zesty): status In Progress Fix Committed
2017-04-18 16:11:21 Andy Whitcroft bug added subscriber Ubuntu Stable Release Updates Team
2017-04-18 16:11:23 Andy Whitcroft bug added subscriber SRU Verification
2017-04-18 16:11:29 Andy Whitcroft tags verification-needed
2017-04-18 16:13:38 Andy Whitcroft thermald (Ubuntu Yakkety): status New Fix Committed
2017-04-18 16:15:08 Andy Whitcroft thermald (Ubuntu Xenial): status New Fix Committed
2017-04-19 09:31:36 Colin Ian King thermald (Ubuntu Yakkety): importance Undecided Medium
2017-04-19 09:31:38 Colin Ian King thermald (Ubuntu Xenial): importance Undecided Medium
2017-04-19 10:27:56 Colin Ian King tags verification-needed verification-done
2017-04-19 20:56:20 Joe Konno bug added subscriber Joe Konno
2017-04-22 09:28:19 Launchpad Janitor thermald (Ubuntu): status Fix Committed Fix Released
2017-04-25 13:17:01 Colin Ian King summary thermald: fix default preference to ENEGERY_CONSERVE thermald: fix default preference to ENERGY_CONSERVE
2017-04-26 04:36:23 Launchpad Janitor thermald (Ubuntu Zesty): status Fix Committed Fix Released
2017-04-26 04:36:30 Andy Whitcroft removed subscriber Ubuntu Stable Release Updates Team
2017-04-26 04:36:56 Launchpad Janitor thermald (Ubuntu Yakkety): status Fix Committed Fix Released
2017-04-26 04:38:03 Launchpad Janitor thermald (Ubuntu Xenial): status Fix Committed Fix Released