Ubuntu
tftp-hpa package

  1. Bug #522509
  2. Comment #8

Comment 8 for bug 522509

Revision history for this message
Steve Langasek (vorlon) wrote :

The start condition in this upstart job is wrong. It should be

  start on (filesystem and net-device-up IFACE!=lo)

The job should also have a stop condition so that the process isn't left running at shutdown:

  stop on runlevel [!2345]

+env DAEMON="/usr/sbin/in.tftpd"

This is not idiomatic. Please list the daemon name directly in the start script, instead of defining a variable that's only used once and should never be overridden.

diff -u tftp-hpa-5.0/debian/rules tftp-hpa-5.0/debian/rules
--- tftp-hpa-5.0/debian/rules
+++ tftp-hpa-5.0/debian/rules
@@ -24 +24 @@
- dh_installinit -a -- start 20 2 3 4 5 . stop 20 1 .
+ dh_installinit -u -- start 20 2 3 4 5 . stop 20 1 .

Has this package been build- and install-tested? By dropping the '-a', that looks to me like you're failing to specify any package at all for dh_installinit to act on. I don't know if that works - AFAICT the behavior is undefined.

Please make the mentioned revisions to the upstart job and send us an updated diff, with confirmation that the package builds and the job starts correctly in testing.