However, I just noticed that '--upstart-only' is the wrong thing to be passing to dh_installinit here. You should only use --upstart-only for upstart jobs that are *not* replacing an existing init script. In this case, there's an existing init script of the same name, so you need to omit --upstart-only in order to pull in the code that cleans up the old init script for us automatically.
Thanks, that looks better.
However, I just noticed that '--upstart-only' is the wrong thing to be passing to dh_installinit here. You should only use --upstart-only for upstart jobs that are *not* replacing an existing init script. In this case, there's an existing init script of the same name, so you need to omit --upstart-only in order to pull in the code that cleans up the old init script for us automatically.
Other than that, FFe granted.