Comment 3 for bug 1946550

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Hi Chris,
I agree that the current code falls through to "Missing mode" due to `while (cp < end && *cp) {` directly skipping the loop on the *cp.

Your check makes this particular case more readable.

But carrying that only as Ubuntu Delta will potentially drive automation mad that would not expect that answer. I'd like to encourage you to submit the very same upstream to be proper part of the next official version.

Upstreams readme [1] asks to discuss things on the syslinux [2] ML.
I found no other contributor hints, so I assume that would be the best place to submit it.

If you happen to do so it would be great if you could add a link to the ML-Archive entry here. That way one can better track what happened in that discussion.

Ubuntu Impish is in final freeze right now anyway and we can't do much.
But I'd hope that your change is upstream accepted and then naturally gets into Ubuntu when we pick up the new version in the next Ubuntu release.

TBH it doesn't seem severe enough to me to SRU [3] the change afterwards.

[1]: https://salsa.debian.org/ron/tftp-hpa/-/blob/debian/README
[2]: https://lists.zytor.com/syslinux
[3]: https://wiki.ubuntu.com/StableReleaseUpdates