telepathy-butterfly crashed with ValueError in Received(): You can't receive the same message twice.

[Francisco Murphy Perez]

Binary package hint: telepathy-butterfly

.I was in invisible mode in empathy....error message appeared several times until u click send report

ProblemType: Crash
DistroRelease: Ubuntu 11.04
Package: telepathy-butterfly 0.5.15-1
ProcVersionSignature: Ubuntu 2.6.38-8.42-generic 2.6.38.2
Uname: Linux 2.6.38-8-generic i686
Architecture: i386
Date: Sat Apr 16 21:02:31 2011
ExecutablePath: /usr/lib/telepathy/telepathy-butterfly
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Beta i386 (20110330)
InterpreterPath: /usr/bin/python2.7
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/lib/telepathy/telepathy-butterfly
ProcEnviron:
 SHELL=/bin/bash
 PATH=(custom, user)
 LANGUAGE=en_US:en
 LANG=en_US.UTF-8
PythonArgs: ['/usr/lib/telepathy/telepathy-butterfly']
SourcePackage: telepathy-butterfly
Title: telepathy-butterfly crashed with ValueError in Received(): You can't receive the same message twice.
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

[Pedro Villavicencio (pedro)]

this report has been filed here:

https://bugs.launchpad.net/ubuntu/+source/telepathy-butterfly/+bug/763242

"I was in invisible mode in empathy....error message appeared several times"

Traceback:

Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/papyon/client.py", line 517, in event
    self._dispatch(method_name, *args[:-1])
  File "/usr/lib/pymodules/python2.7/papyon/event/__init__.py", line 44, in _dispatch
    if event_handler._dispatch_event(name, *args):
  File "/usr/lib/pymodules/python2.7/papyon/event/__init__.py", line 65, in _dispatch_event
    handler(*params)
  File "/usr/lib/python2.7/dist-packages/butterfly/connection.py", line 480, in on_oim_messages_fetched
    channel.offline_message_received(message)
  File "/usr/lib/python2.7/dist-packages/butterfly/channel/im.py", line 194, in offline_message_received
    self._signal_text_received(id, timestamp, handle, type, 0, message.display_name, text)
  File "/usr/lib/python2.7/dist-packages/butterfly/channel/text.py", line 157, in _signal_text_received
    self.Received(id, timestamp, sender, type, flags, text)
  File "/usr/lib/pymodules/python2.7/dbus/decorators.py", line 293, in emit_signal
    func(self, *args, **keywords)
  File "/usr/lib/python2.7/dist-packages/telepathy/server/channel.py", line 296, in Received
    raise ValueError("You can't receive the same message twice.")
ValueError: You can't receive the same message twice.

[Pedro Villavicencio (pedro)]

Thank you for your bug report. This bug has been reported to the developers of the software. You can track it and make comments at:
https://bugs.freedesktop.org/show_bug.cgi?id=37100

[Nathan (nathansamson)]

Created attachment 52173
Fixing the issue by incrementing the recv id correctly.

I've fixed the issue.

The root cause for me was a crash in ButterflyTextChannel._signal_text_received
(UnicodeDecodeError). The message ended up in the pending messages queue, but the current ID did not increase. The attached patch fixes this.

Fixing the crashes in _signal_text_received would also be a good idea (the UnicodeDecodeError has already been reported). The easiest way to fix that would probably be using python 3 instead of python 2...

[Nathan (nathansamson)]

See also https://github.com/nathansamson/Telepathy-Butterfly for my patch in git repo

[Gitlab-migration (gitlab-migration)]

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-butterfly/issues/56.