Comment 2 for bug 2026774

Review for Source Package: tecla

[Summary]
MIR team ACK, ready to be promoted once it gets the team bug subscriber.
This does not need a security review
List of specific binary packages to be promoted to main: tecla

[Duplication]
This package will replace libgnomekbd for Ubuntu Main and allow libgnomekbd to be demoted to Universe.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
- tecla checked with `check-mir`
- all dependencies can be found in `seeded-in-ubuntu` (already in main)
- none of the (potentially auto-generated) dependencies (Depends
  and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

[Common blockers]
OK:
- does not FTBFS currently
- Is UI only and upstream provides no testsuite. There is a test plan and
  committment to cover that continuously.
- no new python2 dependency

[Packaging red flags]
OK:
- Ubuntu does not carry a delta (same package is currently in debian NEW and it will be resync)
- symbols tracking not applicable for this kind of code.
- debian/watch is present and looks ok
- New package, so hard to assess upstream and Debian/Ubuntu update history. However, it will follow GNOME releases.
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
- no massive Lintian warnings
- debian/rules is rather clean
- It is not on the lto-disabled list

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH
- no use of user nobody
- no use of setuid
- no important open bugs (crashers, etc) in Debian or Ubuntu
- no dependency on webkit, qtwebkit, seed or libgoa-*
- part of the UI, desktop file is ok
- translation present (even if not yet fully translated, see description)