Comment 6 for bug 374155

Revision history for this message
dobey (dobey) wrote : Re: [Bug 374155] Re: Tango icon theme does not have the notifiy osd icons

On Wed, 2009-05-13 at 19:11 +0000, Philipp Kern wrote:
> On Wed, May 13, 2009 at 06:55:44PM -0000, Rodney Dawes wrote:
> > This isn't the right fix. It introduces a circular dependency in the
> > theme inheritance tree. Human already Inherits=Tangerine,gnome, and the
> > Tangerine theme Inherits from Tango. The correct solution is to get
> > icons installed into notify-osd's private hicolor theme, so that they
> > are available no matter what theme is available. Adding Human to the
> > Inherits= list in every theme is the wrong answer.
>
> Sure, it would be the right fix. On the other hand I thought that it does
> make sense to fall back to Ubuntu-specific icons in the Human theme even
> with Tango, but bummer, I wasn't aware of the dependency loop. Will
> everything break to pieces with such a loop or will the system cope with
> it?
>
> (Especially considering that tango-icon-theme is in universe I did not
> expect an inheritance to it, having main self-contained.)

Oh, actually it looks like Tangerine doesn't Inherit Tango. I guess that
changed a while ago, and I just didn't realize it. But if it makes sense
to fall back to Human on Ubuntu for all icons, then the right thing to
do is probably either patch GTK+ to fall back to Human before it hits
hicolor, or specify to do so using a system-wide default gtkrc and the
GtkSetting of fallback-icon-theme-name. I think the latter is the
preferred way to do this. However, this of course also inhibits adoption
of notify-osd by other vendors in their distribution, as I'm sure they
won't want to fall back to the Human theme, and probably wouldn't even
ship it.