I think my thought process here was that any PID belonging to an upstart job at the time this was run is astronomically unlikely to get reused for a different process during the shutdown sequence, and I don't think I noticed that we're requerying the list of pids repeatedly in a loop and concatenating the results - that's wrong for obvious reasons.
I haven't looked at your patch, but this looks like a sensible thing to do here. Asking the Foundations team to look at it.
Dan,
I think my thought process here was that any PID belonging to an upstart job at the time this was run is astronomically unlikely to get reused for a different process during the shutdown sequence, and I don't think I noticed that we're requerying the list of pids repeatedly in a loop and concatenating the results - that's wrong for obvious reasons.
I haven't looked at your patch, but this looks like a sensible thing to do here. Asking the Foundations team to look at it.