Comment 8 for bug 1902891

Revision history for this message
Dan Streetman (ddstreet) wrote :

@sampie thanks, I marked that as the upstream bug for this.

For the upstream PR that fixes this:
https://github.com/systemd/systemd/pull/17631

If I'm reading that correctly, that won't actually fix this (the mount will still fail), and it won't add any log messages indicating the actual underlying problem (missing known_hosts ssh key), it will just avoid the repeated mount attempts, right?

I haven't tested the fix myself, just trying to understand if it's "enough" to backport, or if more is needed, either to backport and/or fix upstream. It seems like "fully" fixing this (i.e. adding the remote host key to known_hosts) isn't really something that should be done automatically, since the whole point of asking the user to confirm the host key is because the system can't know if the host key is correct, or a MITM attack. Probably the "best" that could be done, besides existing upstream patch, is to log a message indicating that sshfs failed and possibly include some sshfs detail so users understand what the actual problem is?