Comment 2 for bug 1877159

Revision history for this message
Dan Streetman (ddstreet) wrote :

> https://github.com/systemd/systemd/commit/7d0b26a027118ca063780421cb31c74e9d2664ee

this is fine to include, it's clearly correct (I checked both the upstream kernel as well as wireguard-linux-compat from the ppa, and the param is u16 in both places)

I assume you can easily reproduce this, just by configuring a non-zero WireGuardPeer.PersistentKeepalive value? If so, can you update the SRU template [test case] section? That will need to be filled out before the patch can be sru'ed.

> https://github.com/systemd/systemd/commit/624a47694cad4c87b2e807c32db656f3e9d679c5

I don't think this is needed, it only changes use of sd_netlink_message_append_data() to sd_netlink_message_append_sockaddr_in() - or _in6() - which aren't included in the bionic version of systemd, and from looking at their upstream addition they don't seem to functionally change anything, just add more checking (and simplify the call params). Unless you can point out what the patch specifically fixes, I think we can leave this patch out.