| 2020-03-24 23:18:06 |
Jens Elkner |
bug |
|
|
added bug |
| 2020-03-24 23:18:06 |
Jens Elkner |
attachment added |
|
/usr/share/initramfs-tools/hooks/udev patch https://bugs.launchpad.net/bugs/1868892/+attachment/5341158/+files/networkd-ramfs.patch |
|
| 2020-03-25 00:33:03 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2020-03-25 00:33:12 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2020-03-28 15:12:28 |
Dan Streetman |
bug |
|
|
added subscriber Dan Streetman |
| 2020-04-14 17:56:05 |
Dan Streetman |
nominated for series |
|
Ubuntu Focal |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
bug task added |
|
systemd (Ubuntu Focal) |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
nominated for series |
|
Ubuntu Xenial |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
bug task added |
|
systemd (Ubuntu Xenial) |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
nominated for series |
|
Ubuntu Eoan |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
bug task added |
|
systemd (Ubuntu Eoan) |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
nominated for series |
|
Ubuntu Bionic |
|
| 2020-04-14 17:56:05 |
Dan Streetman |
bug task added |
|
systemd (Ubuntu Bionic) |
|
| 2020-04-14 17:56:16 |
Dan Streetman |
systemd (Ubuntu Xenial): status |
New |
In Progress |
|
| 2020-04-14 17:56:21 |
Dan Streetman |
systemd (Ubuntu Eoan): status |
New |
In Progress |
|
| 2020-04-14 17:56:33 |
Dan Streetman |
systemd (Ubuntu Eoan): importance |
Undecided |
Low |
|
| 2020-04-14 17:56:37 |
Dan Streetman |
systemd (Ubuntu Xenial): assignee |
|
Dan Streetman (ddstreet) |
|
| 2020-04-14 17:56:43 |
Dan Streetman |
systemd (Ubuntu Eoan): assignee |
|
Dan Streetman (ddstreet) |
|
| 2020-04-14 17:56:49 |
Dan Streetman |
systemd (Ubuntu Focal): assignee |
|
Dan Streetman (ddstreet) |
|
| 2020-04-14 17:56:51 |
Dan Streetman |
systemd (Ubuntu Bionic): assignee |
|
Dan Streetman (ddstreet) |
|
| 2020-04-14 17:56:58 |
Dan Streetman |
systemd (Ubuntu Focal): importance |
Undecided |
Low |
|
| 2020-04-14 17:57:01 |
Dan Streetman |
systemd (Ubuntu Xenial): importance |
Undecided |
Low |
|
| 2020-04-14 17:57:03 |
Dan Streetman |
systemd (Ubuntu Bionic): importance |
Undecided |
Low |
|
| 2020-04-14 17:57:05 |
Dan Streetman |
systemd (Ubuntu Focal): status |
New |
In Progress |
|
| 2020-04-14 17:57:08 |
Dan Streetman |
systemd (Ubuntu Bionic): status |
New |
In Progress |
|
| 2020-04-14 18:07:12 |
Dan Streetman |
description |
If one creates e.g. /etc/systemd/network.cu and /etc/systemd/network.fc and symlinks /etc/systemd/network to one of them, network setup will fail on reboot, because /usr/share/initramfs-tools/hooks/udev does a very poor job: it simply checks for a directory instead of the link files and therefore skips copying required files to the ram image. Another poor job is done when copying the files to the ram image: instead of following symlinks it copies them as which in turn makes them useless, because it does not copy the related dirs and thus the symlinks point to nothing. So keeping the system in an consistent state which such poor scripts is very hard, asking for trouble.
Suggested fix is attached. |
[impact]
If the /{etc,lib}/systemd/network directory itself is a symlink, the find
command will not actually find any of the files in the dir it links to.
[test case]
$ sudo touch /etc/systemd/network/lp1868892.link
$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.img-5.4.0-21-generic
...
$ sudo lsinitramfs /boot/initrd.img-5.4.0-21-generic | grep lp1868892
usr/lib/systemd/network/lp1868892.link
$ sudo mv /etc/systemd/network /etc/systemd/network.abc
$ sudo ln -s network.abc /etc/systemd/network
$ sudo update-initramfs -u
$ sudo lsinitramfs /boot/initrd.img-5.4.0-21-generic | grep lp1868892
$
[regression potential]
this adjusts how link files are included in the initramfs, so regressions would likely occur when creating new initramfs, such as failure to create initramfs at all, or failure to properly copy link files into the initramfs, causing network setup failure.
[scope]
this is a Debian/Ubuntu specific file, and the Debian MR was just opened, so this is needed for Debian and all releases of Ubuntu.
[other info]
This bug likely has a very limited impact, as it is uncommon to symlink either the /lib/systemd/network or /etc/systemd/network dirs.
[original description]
If one creates e.g. /etc/systemd/network.cu and /etc/systemd/network.fc and symlinks /etc/systemd/network to one of them, network setup will fail on reboot, because /usr/share/initramfs-tools/hooks/udev does a very poor job: it simply checks for a directory instead of the link files and therefore skips copying required files to the ram image. Another poor job is done when copying the files to the ram image: instead of following symlinks it copies them as which in turn makes them useless, because it does not copy the related dirs and thus the symlinks point to nothing. So keeping the system in an consistent state which such poor scripts is very hard, asking for trouble.
Suggested fix is attached. |
|
| 2020-04-14 18:08:35 |
Dan Streetman |
tags |
patch |
ddstreet patch |
|
| 2020-04-15 19:10:57 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~ddstreet/ubuntu/+source/systemd/+git/systemd/+merge/382329 |
|
| 2020-04-27 15:51:17 |
Łukasz Zemczak |
systemd (Ubuntu Eoan): status |
In Progress |
Fix Committed |
|
| 2020-04-27 15:51:18 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-04-27 15:51:20 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2020-04-27 15:51:24 |
Łukasz Zemczak |
tags |
ddstreet patch |
ddstreet patch verification-needed verification-needed-eoan |
|
| 2020-04-27 19:08:56 |
Łukasz Zemczak |
systemd (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2020-04-27 19:09:03 |
Łukasz Zemczak |
tags |
ddstreet patch verification-needed verification-needed-eoan |
ddstreet patch verification-needed verification-needed-bionic verification-needed-eoan |
|
| 2020-04-28 12:51:03 |
Łukasz Zemczak |
systemd (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2020-04-28 12:51:08 |
Łukasz Zemczak |
tags |
ddstreet patch verification-needed verification-needed-bionic verification-needed-eoan |
ddstreet patch verification-needed verification-needed-bionic verification-needed-eoan verification-needed-xenial |
|
| 2020-05-05 20:23:12 |
Dan Streetman |
tags |
ddstreet patch verification-needed verification-needed-bionic verification-needed-eoan verification-needed-xenial |
ddstreet patch verification-done-xenial verification-needed verification-needed-bionic verification-needed-eoan |
|
| 2020-05-05 20:27:45 |
Dan Streetman |
tags |
ddstreet patch verification-done-xenial verification-needed verification-needed-bionic verification-needed-eoan |
ddstreet patch verification-done-bionic verification-done-xenial verification-needed verification-needed-eoan |
|
| 2020-05-05 20:33:18 |
Dan Streetman |
tags |
ddstreet patch verification-done-bionic verification-done-xenial verification-needed verification-needed-eoan |
ddstreet patch verification-done verification-done-bionic verification-done-eoan verification-done-xenial |
|
| 2020-05-07 10:28:51 |
Launchpad Janitor |
systemd (Ubuntu): status |
In Progress |
Fix Released |
|
| 2020-05-11 15:06:36 |
Launchpad Janitor |
systemd (Ubuntu Eoan): status |
Fix Committed |
Fix Released |
|
| 2020-05-11 15:07:02 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2020-05-11 15:18:51 |
Launchpad Janitor |
systemd (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2020-05-11 15:26:08 |
Launchpad Janitor |
systemd (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2020-05-12 22:06:27 |
Brian Murray |
systemd (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2020-05-12 22:06:29 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-05-12 22:06:33 |
Brian Murray |
tags |
ddstreet patch verification-done verification-done-bionic verification-done-eoan verification-done-xenial |
ddstreet patch verification-done-bionic verification-done-eoan verification-done-xenial verification-needed verification-needed-focal |
|
| 2020-05-13 20:11:56 |
Dan Streetman |
tags |
ddstreet patch verification-done-bionic verification-done-eoan verification-done-xenial verification-needed verification-needed-focal |
ddstreet patch verification-done verification-done-bionic verification-done-eoan verification-done-focal verification-done-xenial |
|
| 2020-05-25 08:07:16 |
Launchpad Janitor |
systemd (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
