initramfs-tools/hooks/udev for network *.link really sucks
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| systemd (Ubuntu) |
Low
|
Dan Streetman | ||
| Xenial |
Low
|
Dan Streetman | ||
| Bionic |
Low
|
Dan Streetman | ||
| Eoan |
Low
|
Dan Streetman | ||
| Focal |
Low
|
Dan Streetman |
Bug Description
[impact]
If the /{etc,lib}
command will not actually find any of the files in the dir it links to.
[test case]
$ sudo touch /etc/systemd/
$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
...
$ sudo lsinitramfs /boot/initrd.
usr/lib/
$ sudo mv /etc/systemd/
$ sudo ln -s network.abc /etc/systemd/
$ sudo update-initramfs -u
$ sudo lsinitramfs /boot/initrd.
$
[regression potential]
this adjusts how link files are included in the initramfs, so regressions would likely occur when creating new initramfs, such as failure to create initramfs at all, or failure to properly copy link files into the initramfs, causing network setup failure.
[scope]
this is a Debian/Ubuntu specific file, and the Debian MR was just opened, so this is needed for Debian and all releases of Ubuntu.
[other info]
This bug likely has a very limited impact, as it is uncommon to symlink either the /lib/systemd/
[original description]
If one creates e.g. /etc/systemd/
Suggested fix is attached.
Related branches
- Dimitri John Ledkov: Pending requested 2020-04-15
-
Diff: 16 lines (+2/-2)1 file modifieddebian/extra/initramfs-tools/hooks/udev (+2/-2)
Jens Elkner (jelmd) wrote : | #1 |
Dan Streetman (ddstreet) wrote : | #3 |
opened Debian MR
https:/
Changed in systemd (Ubuntu Xenial): | |
status: | New → In Progress |
Changed in systemd (Ubuntu Eoan): | |
status: | New → In Progress |
importance: | Undecided → Low |
Changed in systemd (Ubuntu Xenial): | |
assignee: | nobody → Dan Streetman (ddstreet) |
Changed in systemd (Ubuntu Eoan): | |
assignee: | nobody → Dan Streetman (ddstreet) |
Changed in systemd (Ubuntu Focal): | |
assignee: | nobody → Dan Streetman (ddstreet) |
Changed in systemd (Ubuntu Bionic): | |
assignee: | nobody → Dan Streetman (ddstreet) |
Changed in systemd (Ubuntu Focal): | |
importance: | Undecided → Low |
Changed in systemd (Ubuntu Xenial): | |
importance: | Undecided → Low |
Changed in systemd (Ubuntu Bionic): | |
importance: | Undecided → Low |
Changed in systemd (Ubuntu Focal): | |
status: | New → In Progress |
Changed in systemd (Ubuntu Bionic): | |
status: | New → In Progress |
description: | updated |
tags: | added: ddstreet |
Łukasz Zemczak (sil2100) wrote : | #4 |
What is the state of this in focal/groovy? Since I see it as 'In Progress' in focal. From what I see it has been merged in 245.5, right? Focal/groovy seem to be on 245.4. Could we get this fix released to both of those series?
Balint Reczey (rbalint) wrote : | #5 |
@sil2100 The Debian MR landed and I'm fixing it in groovy with the next merge - currently being tested in Bileto. https:/
Łukasz Zemczak (sil2100) wrote : | #6 |
Right, thanks! I also talked with Dan to make sure this change gets backported to focal as well. I won't block on that as the systemd uploads for eoan/bionic/xenial are long overdue, but Dan will make sure this is not forgotten.
Hello Jens, or anyone else affected,
Accepted systemd into eoan-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
Changed in systemd (Ubuntu Eoan): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed verification-needed-eoan |
Łukasz Zemczak (sil2100) wrote : | #8 |
Hello Jens, or anyone else affected,
Accepted systemd into bionic-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
Changed in systemd (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed-bionic |
Jens Elkner (jelmd) wrote : | #9 |
Łukasz Zemczak, yes, upgraded a machine from bionic to focal - same problem. However, the patch looks not optimal but sufficient.
All autopkgtests for the newly accepted systemd (242-7ubuntu3.8) for eoan have finished running.
The following regressions have been reported in tests triggered by the package:
systemd/
prometheus-
gnome-desktop3/
openssh/
snapd/2.42.1+19.10 (i386)
udisks2/unknown (armhf)
umockdev/0.13.2-1 (armhf)
sks/unknown (armhf)
network-
asterisk/unknown (armhf)
logrotate/unknown (armhf)
lxc/3.0.4-0ubuntu1 (i386)
netplan.
dbus/unknown (armhf)
gvfs/1.
Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUp
https:/
[1] https:/
Thank you!
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (systemd/237-3ubuntu10.40) | #11 |
All autopkgtests for the newly accepted systemd (237-3ubuntu10.40) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:
gvfs/1.
prometheus-
systemd/
umockdev/0.11.1-1 (armhf)
linux-hwe-
kde4libs/
util-linux/unknown (armhf)
nftables/unknown (armhf)
linux-raspi2-
netplan.
openssh/
Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUp
https:/
[1] https:/
Thank you!
Hello Jens, or anyone else affected,
Accepted systemd into xenial-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
Changed in systemd (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed-xenial |
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (systemd/229-4ubuntu21.28) | #13 |
All autopkgtests for the newly accepted systemd (229-4ubuntu21.28) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:
udisks2/
multipath-
nplan/0.32~16.04.7 (amd64)
Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUp
https:/
[1] https:/
Thank you!
Dan Streetman (ddstreet) wrote : | #14 |
xenial:
ubuntu@sv-x:~$ dpkg -l systemd|grep systemd
ii systemd 229-4ubuntu21.27 amd64 system and service manager
ubuntu@sv-x:~$ sudo touch /etc/systemd/
ubuntu@sv-x:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
W: mdadm: /etc/mdadm/
ubuntu@sv-x:~$ sudo lsinitramfs /boot/initrd.
lib/systemd/
ubuntu@sv-x:~$ sudo mv /etc/systemd/
ubuntu@sv-x:~$ sudo ln -s network.abc /etc/systemd/
ubuntu@sv-x:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
W: mdadm: /etc/mdadm/
ubuntu@sv-x:~$ sudo lsinitramfs /boot/initrd.
ubuntu@sv-x:~$
ubuntu@sv-x:~$ dpkg -l systemd|grep systemd
ii systemd 229-4ubuntu21.28 amd64 system and service manager
ubuntu@
update-initramfs: Generating /boot/initrd.
W: mdadm: /etc/mdadm/
ubuntu@
lib/systemd/
tags: |
added: verification-done-xenial removed: verification-needed-xenial |
Dan Streetman (ddstreet) wrote : | #15 |
bionic:
ubuntu@sv-b:~$ dpkg -l udev|grep udev
ii udev 237-3ubuntu10.39 amd64 /dev/ and hotplug management daemon
ubuntu@sv-b:~$ sudo touch /etc/systemd/
ubuntu@sv-b:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
ubuntu@sv-b:~$ sudo lsinitramfs /boot/initrd.
lib/systemd/
ubuntu@sv-b:~$ sudo mv /etc/systemd/
ubuntu@sv-b:~$ sudo ln -s network.abc /etc/systemd/
ubuntu@sv-b:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
ubuntu@sv-b:~$ sudo lsinitramfs /boot/initrd.
ubuntu@sv-b:~$
ubuntu@sv-b:~$ dpkg -l udev |grep udev
ii udev 237-3ubuntu10.40 amd64 /dev/ and hotplug management daemon
ubuntu@sv-b:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
ubuntu@sv-b:~$ sudo lsinitramfs /boot/initrd.
lib/systemd/
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
Dan Streetman (ddstreet) wrote : | #16 |
eoan:
ubuntu@sv-e:~$ dpkg -l udev|grep udev
ii udev 242-7ubuntu3.7 amd64 /dev/ and hotplug management daemon
ubuntu@sv-e:~$ sudo touch /etc/systemd/
ubuntu@sv-e:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
ubuntu@sv-e:~$ sudo lsinitramfs /boot/initrd.
usr/lib/
ubuntu@sv-e:~$ sudo mv /etc/systemd/
ubuntu@sv-e:~$ sudo ln -s network.abc /etc/systemd/
ubuntu@sv-e:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
ubuntu@sv-e:~$ sudo lsinitramfs /boot/initrd.
ubuntu@sv-e:~$
ubuntu@sv-e:~$ dpkg -l udev|grep udev
ii udev 242-7ubuntu3.8 amd64 /dev/ and hotplug management daemon
ubuntu@sv-e:~$ sudo update-initramfs -u
update-initramfs: Generating /boot/initrd.
ubuntu@sv-e:~$ sudo lsinitramfs /boot/initrd.
usr/lib/
tags: |
added: verification-done verification-done-eoan removed: verification-needed verification-needed-eoan |
Launchpad Janitor (janitor) wrote : | #17 |
This bug was fixed in the package systemd - 245.5-2ubuntu1
---------------
systemd (245.5-2ubuntu1) groovy; urgency=medium
* Merge to Ubuntu from Debian unstable
- Dropped changes: none
systemd (245.5-2) unstable; urgency=medium
* Cherry-pick various fixes from upstream master
- network: add a flag to ignore gateway provided by DHCP server
- userdb: when doing client-side NSS look-ups optionally avoid shadow
look-ups
- nss-systemd: don't synthesize root/nobody when iterating
- core: make sure we don't get confused when setting TERM for a tty fd
- core: make sure to restore the control command id, too
* Install 60-block.rules in udev-udeb and initramfs-tools.
The block device rules were split out from 60-persistent-
into its own rules file in v220. Those rules ensure that change events
are emitted and the udev db is updated after metadata changes.
Thanks to Pascal Hambourg (Closes: #958397)
systemd (245.5-1ubuntu1) groovy; urgency=medium
* Merge to Ubuntu from Debian unstable
- Dropped changes: none
systemd (245.5-1) unstable; urgency=medium
[ Michael Biebl ]
* New upstream version 245.5
* Rebase patches
[ Dan Streetman ]
* Follow symlinks when finding link files to copy into initramfs.
If the /{etc,lib}
command will not actually find any of the files in the dir it links to.
Use the find -L param to follow symlinks.
(LP: #1868892)
* Remove Ubuntu-specific ondemand.service.
New processors handle scaling/throttling in internal firmware
(e.g. intel_pstate), and do not require OS config.
Additionally, nobody else does this, not even Debian.
-- Balint Reczey <email address hidden> Tue, 28 Apr 2020 13:20:31 +0200
Changed in systemd (Ubuntu): | |
status: | In Progress → Fix Released |
Launchpad Janitor (janitor) wrote : | #18 |
This bug was fixed in the package systemd - 242-7ubuntu3.8
---------------
systemd (242-7ubuntu3.8) eoan; urgency=medium
* d/t/logind: skip if nonexistent /sys/power/state (LP: #1862657)
* d/p/lp1859862-
- enable ipv6 when needed (LP: #1859862)
* d/p/lp1858412-
- allow vacuuming journal 'root' dir (LP: #1858412)
* d/rules: use meson --print-errorlogs instead of cat testlog
- (LP: #1870811)
* d/p/lp1776654-
- sync journal before reading from it (LP: #1776654)
* d/p/lp1837914-
- do not crash if NULL passted to journal destructor (LP: #1837914)
* d/e/initramfs-
- Follow symlinks when finding link files to copy into initramfs
(LP: #1868892)
-- Dan Streetman <email address hidden> Mon, 20 Apr 2020 09:44:51 -0400
Changed in systemd (Ubuntu Eoan): | |
status: | Fix Committed → Fix Released |
The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.
Launchpad Janitor (janitor) wrote : | #20 |
This bug was fixed in the package systemd - 237-3ubuntu10.40
---------------
systemd (237-3ubuntu10.40) bionic; urgency=medium
* d/t/logind: skip if nonexistent /sys/power/state (LP: #1862657)
* d/p/lp1839290-
- when restarting service after failure, replace existing queued jobs
(LP: #1839290)
* d/p/lp1867421-
- fix resolution of IntelliMouse (LP: #1867421)
* d/p/lp1858412-
- allow vacuuming journal 'root' dir (LP: #1858412)
* d/p/lp1862232/
d/p/
d/p/
d/p/
d/p/
d/p/
d/p/
- do not fail network setup if hostname is not valid (LP: #1862232)
* d/t/systemd-fsckd: Skip test on arm64 (LP: #1870194)
* d/p/lp1870589-
- fix test-seccomp failure (LP: #1870589)
* d/rules: use meson --print-errorlogs instead of cat testlog
- (LP: #1870811)
* d/p/lp1776654-
- sync journal before reading from it (LP: #1776654)
* d/p/lp1837914-
- do not crash if NULL passted to journal destructor (LP: #1837914)
* d/e/initramfs-
- Follow symlinks when finding link files to copy into initramfs
(LP: #1868892)
-- Dan Streetman <email address hidden> Mon, 20 Apr 2020 10:12:49 -0400
Changed in systemd (Ubuntu Bionic): | |
status: | Fix Committed → Fix Released |
Launchpad Janitor (janitor) wrote : | #21 |
This bug was fixed in the package systemd - 229-4ubuntu21.28
---------------
systemd (229-4ubuntu21.28) xenial; urgency=medium
* d/t/logind: skip if nonexistent /sys/power/state (LP: #1862657)
* d/p/lp1839290-
- when restarting service after failure, replace existing queued jobs
(LP: #1839290)
* d/t/storage:
- fix buggy test (LP: #1831459)
- without scsi_debug, skip test (LP: #1847816)
* d/p/lp1867421-
- fix resolution of IntelliMouse (LP: #1867421)
* d/p/lp1858412-
- allow vacuuming journal 'root' dir (LP: #1858412)
* d/p/lp1862232-
- do not let invalid hostname break dhcpv4 (LP: #1862232)
* d/t/systemd-fsckd: Skip test on arm64 (LP: #1870194)
* d/p/lp1837914-
- do not crash if NULL passted to journal destructor (LP: #1837914)
* d/e/initramfs-
- Follow symlinks when finding link files to copy into initramfs
(LP: #1868892)
-- Dan Streetman <email address hidden> Mon, 20 Apr 2020 10:17:40 -0400
Changed in systemd (Ubuntu Xenial): | |
status: | Fix Committed → Fix Released |
Hello Jens, or anyone else affected,
Accepted systemd into focal-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
Changed in systemd (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-needed verification-needed-focal removed: verification-done |
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (systemd/245.4-4ubuntu3.1) | #23 |
All autopkgtests for the newly accepted systemd (245.4-4ubuntu3.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:
hddemux/unknown (armhf)
pyudev/unknown (armhf)
python-
prometheus/
gvfs/unknown (armhf)
indicator-
gpsd/unknown (armhf)
samba/unknown (armhf)
python-
golang-
pystemd/unknown (armhf)
umockdev/0.14.1-1 (armhf)
remctl/unknown (armhf)
icinga2/unknown (armhf)
gnome-desktop3/
munin/2.
haproxy/unknown (armhf)
python-
gvfs/1.
Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUp
https:/
[1] https:/
Thank you!
Dan Streetman (ddstreet) wrote : | #24 |
focal:
ubuntu@
ii systemd 245.4-4ubuntu3 amd64 system and service manager
ubuntu@
ubuntu@
update-initramfs: Generating /boot/initrd.
ubuntu@
usr/lib/
ubuntu@
ubuntu@
ubuntu@
update-initramfs: Generating /boot/initrd.
ubuntu@
ubuntu@
ubuntu@
ubuntu@
ubuntu@
update-initramfs: Generating /boot/initrd.
ubuntu@
usr/lib/
ubuntu@
ii systemd 245.4-4ubuntu3.1 amd64 system and service manager
ubuntu@
ubuntu@
update-initramfs: Generating /boot/initrd.
ubuntu@
usr/lib/
ubuntu@
ubuntu@
ubuntu@
update-initramfs: Generating /boot/initrd.
ubuntu@
usr/lib/
tags: |
added: verification-done verification-done-focal removed: verification-needed verification-needed-focal |
Launchpad Janitor (janitor) wrote : | #25 |
This bug was fixed in the package systemd - 245.4-4ubuntu3.1
---------------
systemd (245.4-4ubuntu3.1) focal; urgency=medium
* d/p/lp1867375/
d/p/
d/p/
d/p/
d/p/
d/p/
- Add UseGateway= parameter and default to value of UseRoutes, to restore
backwards compatibility with old UseRoutes= behavior (LP: #1867375)
* d/p/lp1860926-
- default ignore_carrier_loss to value of configure_
so carrier drop during configuration doesn't break networking
(LP: #1860926)
* d/e/initramfs-
- Follow symlinks when finding link files to copy into initramfs
(LP: #1868892)
* d/p/lp1873607/
d/
- Avoid segfault during serialization (LP: #1873607)
-- Dan Streetman <email address hidden> Thu, 07 May 2020 09:21:22 -0400
Changed in systemd (Ubuntu Focal): | |
status: | Fix Committed → Fix Released |
The attachment "/usr/share/ initramfs- tools/hooks/ udev patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.
[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]