Comment 5 for bug 1750013

Revision history for this message
Dan Streetman (ddstreet) wrote :

This does not look right to me:

@@ -951,6 +952,7 @@
                 free(s->fifo_path);
                 s->fifo_path = NULL;
         }
+ session_add_to_gc_queue(s);
 }

 int session_check_gc(Session *s, bool drop_not_started) {

that puts the session on the manager's gc queue, however this function (session_remove_fifo) is called from session_free(), which is called from the manager's gc queue handler...can you explain why this is needed here?

The other parts of the patch look good, thanks!