system-config-printer shouldn't use notifications with actions

Bug #328604 reported by David Barth on 2009-02-12
16
Affects Status Importance Assigned to Milestone
system-config-printer (Ubuntu)
Undecided
Ken VanDine

Bug Description

Binary package hint: system-config-printer

When a printer is added successfully using a matching printer driver, a “Printer added” notification bubble appears containing the text “`%s' is ready for printing.” and a “Configure” button. Instead, the Properties window for that printer should open unfocused directly.

When a printer is added successfully using a non-matching printer driver, a “Printer added” notification bubble appears containing the text “%s' has been added, using the %s' driver.” and a “Find driver” button. (system-config-printer 1.1 will also include a “Print test page” button.) Instead, the Properties window for that printer should open unfocused.

When you try to view jobs on a printer that requires authentication, an “Authentication required” notification bubble appears containing the text “Job requires authentication to proceed” and an “Authenticate” button that brings up an alert box saying “Authentication required for printing document `%s' (job %d)”. The notification bubble should be abolished, and the alert box should be invoked directly instead.

When a print job gets stuck for some reason, a notification bubble appears containing text “There was a problem processing the document” or similar, containing no buttons but staying open until it is clicked. This should be converted to an error alert box with an “OK” button.

Till Kamppeter (till-kamppeter) wrote :

Please report these suggestions for the user interface upstream at

https://fedorahosted.org/system-config-printer/

Alexander Sack (asac) wrote :

In general, I think making multiple bugs out of it makes it easier to upstream the individual parts. One issue might be easier to convince upstream about, the other might not.

David Barth (dbarth) wrote :

Here is a patch to make s-c-p work better according to the new notification guidelines. It also supports the straciatella session mechanism, for users who prefer to have action buttons on their notifications.

Martin Pitt (pitti) wrote :

Just in case someone sponsors/forwards this:

 - os.environ['gnome-stracciatella'] is wrong; it should be

    os.environ.get('GDMSESSION') == 'gnome-stracciatella'

 - for the "# Model mismatch" case, does --configure-printer really make sense instead of the previous "Print test page"/"Find driver" options? does --configure-printer just spawn the s-c-p GUI?

David Barth (dbarth) wrote :

Fixed patch. Thanks for your help (and Ken too)

- for the model mistmatch case --configure-printer displays the printer configuration dialog which allows to (1) change the driver (2) print a test page
- --configure-printer spawns the s-c-p- GUI yes

Changed in system-config-printer:
assignee: nobody → ken-vandine
status: New → In Progress
Ken VanDine (ken-vandine) wrote :

Added patch in a debdiff

Martin Pitt (pitti) wrote :

Ken,

your patch seems to miss more than half of David's patch; it seems that your debdiff changes an existing debian/patches/26_notification.patch, but the current jaunty package doesn't have that.

Why did you do this mv $(CURDIR)/debian/tmp/usr/local/lib $(CURDIR)/debian/tmp/usr/? That looks fishy, and obviously wasn't required before.

While you are at it, could you please fix

  os.environ['GDMSESSION'] -> os.environ.get('GDMSESSION')

? I already pointed that out above, but seems to have slipped (we don't want the program to crash with a KeyError if $GDMSESSION isn't defined at all). Thanks!

Ken VanDine (ken-vandine) wrote :

Updated debdiff, should be full patch as well as fixed os.environ references

I had to do the mv because it was putting things in tmp/usr/local/lib, no idea why.

Martin Pitt (pitti) wrote :

mv> ah, that's because setup.py isn't called with --install-layout=deb, and due to the wrapped automake/python-setuptools this can't be done in debian/rules. I'll create a patch for that.

Martin Pitt (pitti) wrote :

@Ken: Above (/usr/local) changed recently with Python 2.6 FYI, so it wasn't broken that way before.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package system-config-printer - 1.1.3+git20090218-0ubuntu4

---------------
system-config-printer (1.1.3+git20090218-0ubuntu4) jaunty; urgency=low

  [ Ken VanDine ]
  * Add 26_notification.patch: don't use actions in notifications unless using
    the gnome-stracciatella session (LP: #328604)

  [ Martin Pitt ]
  * Add 02_install_layout.patch: --install-layout=deb to "setup.py install"
    call in Makefile.{am,in}. This makes the package install correctly with
    Python 2.6.

 -- Martin Pitt <email address hidden> Wed, 04 Mar 2009 23:55:00 +0100

Changed in system-config-printer:
status: In Progress → Fix Released
Matthew Paul Thomas (mpt) wrote :

(The fix for this bug inappropriately checked for the gnome-stracciatella session, causing bug 339847. If you're reading this bug report to learn how to make actions conditional in notification bubbles, please instead read <https://wiki.ubuntu.com/NotificationDevelopmentGuidelines#Avoiding%20actions>.)

mpt: Not sure that's the right place to do so, but I'd like you to consider two issues about how system-config-printer handles notifications. Maybe they should go upstream if you think they're accurate.

- As specified in notify-osd plan in the wiki, the "Printer added" notification, which says "`%s' is ready for printing.", is now accompanied by the Properties dialog. I think that's not a good idea, because as the bubble says, the printer is *already* configured, and works in most cases. If you're an advanced user, you can still start this dialog manually, but there's no need to scare users with that complex dialog: they will believe they need to change something (e.g. the URI, first complex thing that is shown) when they could just print their document and get it. Just showing the notification should be enough.

- When a document has been printed, a bubble titled "Job #XXX" says something like "The printing is done." IMO the title should be either the name of the document (often very accurate, see Evince or OO.o), or "Document printed". Who cares about job numbers?!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments