Comment 7 for bug 328604

Revision history for this message
Martin Pitt (pitti) wrote :

Ken,

your patch seems to miss more than half of David's patch; it seems that your debdiff changes an existing debian/patches/26_notification.patch, but the current jaunty package doesn't have that.

Why did you do this mv $(CURDIR)/debian/tmp/usr/local/lib $(CURDIR)/debian/tmp/usr/? That looks fishy, and obviously wasn't required before.

While you are at it, could you please fix

  os.environ['GDMSESSION'] -> os.environ.get('GDMSESSION')

? I already pointed that out above, but seems to have slipped (we don't want the program to crash with a KeyError if $GDMSESSION isn't defined at all). Thanks!