Comment 17 for bug 211347

Revision history for this message
Koen (koen-beek) wrote :

Hi,

  indeed increasing the limit by one isn't too great as a solution

  the major correction though, is that limit checking is being applied while it wasn't before - if there are more than 6 usb-controllers, only the first 6 will be shown but the program will not fail and will show all the other hardware.

  before this change when more than 5 usb controllers where mentioned in the 'lspci -v' list, the program would stop detecting any other hardware in the 'lspci -v' list when it reached the 6th usb controller and it would produce a 'IndexOutOfRangeException' exception - any hardware listed in lspci -v from the 6th usb controller was therefore missing from the sysinfo gui

  I chose this way of correcting the code to limit the size of the code changes to a minimum and because my mono programming skills are very small - I've only used Mono for sysinfo bug corrections
  I could easily increase the limit to a size that will be sufficient for 99.999% of all machines (for example 10 usb controllers) but it would take me much more effort to get a truly dynamic list size as I'm not accustomed to Mono development

  I'll add the bug reports and a link to the patches upstream but I think upstream might be dead since +- middle of 2006

     Koen